-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last mile navigation feature #35
Open
AKalinich-Luxoft
wants to merge
9
commits into
develop
Choose a base branch
from
feature/last_mile_navigation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for de2870a - Browse repository at this point
Copy the full SHA de2870aView commit details -
Implement locations sorting using timestamp param
Added processing new params for SendLocation
Configuration menu - View commit details
-
Copy full SHA for a00ac6e - Browse repository at this point
Copy the full SHA a00ac6eView commit details -
Add waypoint directions images
Added set of new png images for navigation module.
Configuration menu - View commit details
-
Copy full SHA for 0403e41 - Browse repository at this point
Copy the full SHA 0403e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6073dd5 - Browse repository at this point
Copy the full SHA 6073dd5View commit details -
Implemented waypoints logic and related RPCs
Related RPC for work with waypoints information according to proposal: GetWayPoints, SubscribeWayPoints, UnsubscribeWayPoints, OnWayPointsChanged.
Configuration menu - View commit details
-
Copy full SHA for 111daac - Browse repository at this point
Copy the full SHA 111daacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c2911c - Browse repository at this point
Copy the full SHA 1c2911cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20b40c6 - Browse repository at this point
Copy the full SHA 20b40c6View commit details -
1. Click anywhere on the map: (current behavior, no change) 1.1 If there is no active mark on the map, place a pin/marker on the map to show the current selected location. 1.2 If there is an active mark on the map, move the current marker to the new location. (Remove the current pin and place one on new location) 2. Button “Waypoints”: (changes) 2.1 If the waypoint list is not empty, it shall toggle the state of showing a list of waypoints and hide the list. 2.2 If the list is empty, shall show an error message or show an empty list or get disabled. 3. Button “Add WayPoint”: (changes) 3.1 If there is a selected location (active mark), add the location to the waypoints list and show the waypoint list so that the user knows it (also send onWayPointChange Notification if needed). 3.2 If there is no active mark on the map, show a message ask user to place a mark on the map first before click the button. 4. Button “Clear”: clear all marks on the map. (new button) 5. Button “Start Animation”/”Stop Animation”: start/stop animation. (current behavior, no change) 6. Button “Navigate”: 6.1 If there is a selected location, set it as the destination (new last waypoint). Calculate and show the route. 6.2 If there is no selected location, (changes) and 6.2.1 If the waypoint is not empty, set the last waypoint as destination, calculate and show the route. 6.2.2 If the waypoint is empty, show a message ask user to set a destination. 7. “Places” button. – not used. 8. Need to change the inscription "Please select a WayPoint" to "Please select a place on the map".
Configuration menu - View commit details
-
Copy full SHA for b92e7ab - Browse repository at this point
Copy the full SHA b92e7abView commit details -
Removed unused places functionality from navi module.
Fixed SendLocation hanlders to work with waypoints. Small updates in waypoints logic.
Configuration menu - View commit details
-
Copy full SHA for b8c7648 - Browse repository at this point
Copy the full SHA b8c7648View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.