Feature/Remote Control - Allow Multiple Modules per Module Type #171

LitvinenkoIra · 2019-08-05T12:02:08Z

Provides the information for #2919

Proposal: Remote Control - Allow Multiple Modules per Module Type

This PR is ready for review.

Summary

HMI guidelines for SDL evolution issue: smartdevicelink/sdl_evolution#700

add new ModuleInfo struct
ModuleData -> add moduleId param
add new Grid struct
add struct SeatLocation
add new struct SeatLocationCapability
ClimateControlCapabilities -> add moduleInfo
RadioControlCapabilities -> add moduleInfo
ButtonCapabilities -> add moduleInfo
AudioControlCapabilities -> add moduleInfo
HMISettingsControlCapabilities -> add moduleInfo
LightControlCapabilities -> add moduleInfo
SeatControlCapabilities -> add moduleInfo
SeatControlData - id -> mandatory=false
SystemCapability struct - > add "seatLocationCapability"

Enums

remove SupportedSeat
SystemCapabilityType -> add SEAT_LOCATION

Functions

GetInteriorVehicleData_request -> add moduleId, add subscribe description
ButtonPress add "moduleId"
GetInteriorVehicleDataConsent_request -> add moduleIds
GetInteriorVehicleDataConsent_response -> "allowed" add array="true"
RC.GetCapabilities_response -> add param name="seatLocationCapability"
RC.SetGlobalProperties - create index.md, add diagram

CLA

I have signed the CLA

1 add new ModuleInfo struct 2 ModuleData -> add `moduleId` param 3 add new Grid struct 4 add struct SeatLocation 5 add new struct SeatLocationCapability 6. ClimateControlCapabilities -> add `moduleInfo` 7. RadioControlCapabilities -> add `moduleInfo` 8. ButtonCapabilities -> add `moduleInfo` 9. AudioControlCapabilities -> add `moduleInfo` 10. HMISettingsControlCapabilities -> add `moduleInfo` 11. LightControlCapabilities -> add `moduleInfo` 12. SeatControlCapabilities -> add `moduleInfo` 13. SeatControlData - remove `id` param 14. SystemCapability struct - > add "seatLocationCapability" Enums 1. remove SupportedSeat 2. SystemCapabilityType -> add SEAT_LOCATION Functions 1. GetInteriorVehicleData_request -> add `moduleId`, add `subscribe` description 2. ButtonPress add "moduleId" 3. GetInteriorVehicleDataConsent_request -> add `moduleIds` 4. GetInteriorVehicleDataConsent_response -> "allowed" add array="true" 5. TTS.SetGlobalProperties_request -> add param `userLocation` 6. RC.GetCapabilities_response -> add param name="seatLocationCapability"

added per revision smartdevicelink/sdl_evolution#786

…eLinkMirror/sdl_hmi_integration_guidelines into feature/multiple_modules

…nRCStatus index

sdl-robot · 2019-08-05T12:02:55Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/3a281bcee23986d6e31c19ef53fc887d3c9dd1d8/overview/

sdl-robot · 2019-08-05T12:02:58Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/3a281bcee23986d6e31c19ef53fc887d3c9dd1d8/overview/

mrapitis · 2019-08-19T18:35:35Z

@theresalech Ford has approved of these changes.

sdl-robot · 2019-08-28T06:56:40Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/d9e5e0f1efbbc9a0df4156bab3ef1bbe41cdccc3/overview/

sdl-robot · 2019-08-28T06:56:41Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/d9e5e0f1efbbc9a0df4156bab3ef1bbe41cdccc3/overview/

…improvments

…vicelink/sdl_hmi_integration_guidelines into feature/multiple_modules

sdl-robot · 2019-09-05T14:37:44Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/1bf57499dd906f22bb4c0bff97628fc02f3d5e92/overview/

sdl-robot · 2019-09-05T14:37:47Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/1bf57499dd906f22bb4c0bff97628fc02f3d5e92/overview/

docs/TTS/SetGlobalProperties/index.md

docs/RC/OnRCStatus/index.md

docs/RC/OnInteriorVehicleData/index.md

docs/RC/GetInteriorVehicleDataConsent/index.md

docs/RC/GetInteriorVehicleDataConsent/assets/GetInteriorVehicleDataConsent.gliffy

docs/RC/GetInteriorVehicleData/index.md

docs/Common/Structs/index.md

Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>

sdl-robot · 2019-09-09T08:30:00Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/468e05777fabe9b8b7396bdd016eb8c5d669ed16/overview/

sdl-robot · 2019-09-09T08:30:00Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/468e05777fabe9b8b7396bdd016eb8c5d669ed16/overview/

sdl-robot · 2019-09-09T08:30:12Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/468e05777fabe9b8b7396bdd016eb8c5d669ed16/overview/

sdl-robot · 2019-09-09T08:30:16Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/468e05777fabe9b8b7396bdd016eb8c5d669ed16/overview/

sdl-robot · 2019-09-09T09:56:11Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/69633f8c0fab3d34eb93abb36eb4780f8bea2ad1/overview/

sdl-robot · 2019-09-09T09:56:11Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/69633f8c0fab3d34eb93abb36eb4780f8bea2ad1/overview/

Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>

sdl-robot · 2019-09-09T10:19:00Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/49b982b63b94bf421398ff45e73b4d4e712dffe9/overview/

sdl-robot · 2019-09-09T10:21:59Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/59936e40b204b542b7de0a6b4a5706e0ccec14f8/overview/

sdl-robot · 2019-09-09T10:21:59Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/59936e40b204b542b7de0a6b4a5706e0ccec14f8/overview/

sdl-robot · 2019-09-09T11:11:05Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/b82314d840a58d2d8326fe994b10e689acedabde/overview/

sdl-robot · 2019-09-09T11:11:05Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/b82314d840a58d2d8326fe994b10e689acedabde/overview/

ShobhitAd · 2019-09-09T13:35:38Z

In this feature, the SetGlobalProperties RPC was added for the RC interface https://github.com/smartdevicelink/sdl_core/pull/2984/files#diff-f81183d34277b39fa042fd7e4eed256fR6802. We will have to add a RC/SetGlobalProperties/index.md file documenting RC.SetGlobalProperties

…vicelink/sdl_hmi_integration_guidelines into feature/multiple_modules

sdl-robot · 2019-09-09T15:31:16Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/e34f968ffee10537f1c423365995b711420d274e/overview/

sdl-robot · 2019-09-09T15:31:18Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/e34f968ffee10537f1c423365995b711420d274e/overview/

KhrystynaDubovyk · 2019-09-09T15:34:26Z

In this feature, the SetGlobalProperties RPC was added for the RC interface https://github.com/smartdevicelink/sdl_core/pull/2984/files#diff-f81183d34277b39fa042fd7e4eed256fR6802. We will have to add a RC/SetGlobalProperties/index.md file documenting RC.SetGlobalProperties

@ShobhitAd, please see RC/SetGlobalProperties/index.md in a19e0a8

sdl-robot · 2019-09-09T16:19:44Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/a72d1d61ed08ac207d139bc0ae59d49870c6d123/overview/

sdl-robot · 2019-09-09T16:19:45Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/a72d1d61ed08ac207d139bc0ae59d49870c6d123/overview/

ShobhitAd · 2019-09-09T19:51:38Z

In this feature, the SetGlobalProperties RPC was added for the RC interface https://github.com/smartdevicelink/sdl_core/pull/2984/files#diff-f81183d34277b39fa042fd7e4eed256fR6802. We will have to add a RC/SetGlobalProperties/index.md file documenting RC.SetGlobalProperties

@ShobhitAd, please see RC/SetGlobalProperties/index.md in a19e0a8

@KhrystynaDubovyk Thanks for making the changes so quickly. We should also add

{
    "name": "SetGlobalProperties"
}

to the config.json file https://github.com/smartdevicelink/sdl_hmi_integration_guidelines/blob/feature/multiple_modules/config.json#L489

sdl-robot · 2019-09-09T20:38:48Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/2a62528f72c3174546b39dc41fd0c846e414e8f4/overview/

sdl-robot · 2019-09-09T20:38:48Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/2a62528f72c3174546b39dc41fd0c846e414e8f4/overview/

KhrystynaDubovyk · 2019-09-09T20:42:23Z

@ShobhitAd, please see the updates to config.json in 2a62528

docs/RC/SetGlobalProperties/index.md

Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>

sdl-robot · 2019-09-10T06:15:10Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/1c124924fca6e9f60a433c4799602d495f74006b/overview/

sdl-robot · 2019-09-10T06:15:14Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/1c124924fca6e9f60a433c4799602d495f74006b/overview/

sdl-robot · 2019-09-10T06:15:52Z

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/de249c04759674b8befb3be7d380a6d5e27820b9/overview/

sdl-robot · 2019-09-10T06:15:54Z

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/de249c04759674b8befb3be7d380a6d5e27820b9/overview/

KhrystynaDubovyk and others added 5 commits July 4, 2019 22:07

Update RC.GetCapabilities must section

ce54edb

added id mandatory=false to SeatControlData

41c34b3

added per revision smartdevicelink/sdl_evolution#786

Merge branch 'feature/multiple_modules' of github.ford.com:SmartDevic…

05d59a9

…eLinkMirror/sdl_hmi_integration_guidelines into feature/multiple_modules

upd GetCapabilities, GetInteriorVehicleData, OnInteriorVehicleData, O…

3a281bc

…nRCStatus index

LitvinenkoIra mentioned this pull request Aug 5, 2019

Feature/Remote Control - Allow Multiple Modules per Module Type smartdevicelink/sdl_core#2984

Merged

1 task

AStasiuk requested a review from mrapitis August 6, 2019 06:53

mrapitis approved these changes Aug 19, 2019

View reviewed changes

theresalech requested a review from ShobhitAd August 19, 2019 18:45

Merge branch 'develop' into feature/multiple_modules

d9e5e0f

KhrystynaDubovyk added 2 commits September 4, 2019 15:50

upd Consent diagr;GetCapabilities,GetInteriorVehicleData index minor …

31b1fd6

…improvments

Merge branch 'feature/multiple_modules' of https://github.com/smartde…

1bf5749

…vicelink/sdl_hmi_integration_guidelines into feature/multiple_modules

ShobhitAd requested changes Sep 6, 2019

View reviewed changes

Apply suggestions from code review

468e057

Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>

remove userLocation from TTS.SetGlobalProperties

69633f8

remove defvalue for subscribe param

49b982b

Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>

fix typos in diagr (concent ->consent)

b82314d

KhrystynaDubovyk added 3 commits September 9, 2019 17:54

add SetGlobalProperties index

6588d67

SetGlobalProperties index

a19e0a8

Merge branch 'feature/multiple_modules' of https://github.com/smartde…

e34f968

…vicelink/sdl_hmi_integration_guidelines into feature/multiple_modules

add RC_SetGlobalProperties.png,RC_SetGlobalProperties.gliffy

a72d1d6

add SetGlobalProperties to RC

2a62528

ShobhitAd requested changes Sep 9, 2019

View reviewed changes

docs/RC/SetGlobalProperties/index.md Outdated Show resolved Hide resolved

docs/RC/SetGlobalProperties/index.md Outdated Show resolved Hide resolved

docs/RC/SetGlobalProperties/index.md Outdated Show resolved Hide resolved

KhrystynaDubovyk and others added 2 commits September 10, 2019 09:14

Apply suggestions from code review

1c12492

Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>

remove p.2

de249c0

ShobhitAd approved these changes Sep 10, 2019

View reviewed changes

ShobhitAd merged commit 42a0185 into develop Sep 10, 2019

ShobhitAd deleted the feature/multiple_modules branch September 10, 2019 13:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/Remote Control - Allow Multiple Modules per Module Type #171

Feature/Remote Control - Allow Multiple Modules per Module Type #171

LitvinenkoIra commented Aug 5, 2019 •

edited by KhrystynaDubovyk

Loading

sdl-robot commented Aug 5, 2019

sdl-robot commented Aug 5, 2019

mrapitis commented Aug 19, 2019

sdl-robot commented Aug 28, 2019

sdl-robot commented Aug 28, 2019

sdl-robot commented Sep 5, 2019

sdl-robot commented Sep 5, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

ShobhitAd commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

KhrystynaDubovyk commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

ShobhitAd commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

KhrystynaDubovyk commented Sep 9, 2019

sdl-robot commented Sep 10, 2019

sdl-robot commented Sep 10, 2019

sdl-robot commented Sep 10, 2019

sdl-robot commented Sep 10, 2019

Feature/Remote Control - Allow Multiple Modules per Module Type #171

Feature/Remote Control - Allow Multiple Modules per Module Type #171

Conversation

LitvinenkoIra commented Aug 5, 2019 • edited by KhrystynaDubovyk Loading

Summary

CLA

sdl-robot commented Aug 5, 2019

sdl-robot commented Aug 5, 2019

mrapitis commented Aug 19, 2019

sdl-robot commented Aug 28, 2019

sdl-robot commented Aug 28, 2019

sdl-robot commented Sep 5, 2019

sdl-robot commented Sep 5, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

ShobhitAd commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

KhrystynaDubovyk commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

ShobhitAd commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

sdl-robot commented Sep 9, 2019

KhrystynaDubovyk commented Sep 9, 2019

sdl-robot commented Sep 10, 2019

sdl-robot commented Sep 10, 2019

sdl-robot commented Sep 10, 2019

sdl-robot commented Sep 10, 2019

LitvinenkoIra commented Aug 5, 2019 •

edited by KhrystynaDubovyk

Loading