-
Notifications
You must be signed in to change notification settings - Fork 24
Feature/Remote Control - Allow Multiple Modules per Module Type #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7892699
Stucts
KhrystynaDubovyk ce54edb
Update RC.GetCapabilities must section
41c34b3
added `id` mandatory=false to SeatControlData
KhrystynaDubovyk 05d59a9
Merge branch 'feature/multiple_modules' of github.ford.com:SmartDevic…
KhrystynaDubovyk 3a281bc
upd GetCapabilities, GetInteriorVehicleData, OnInteriorVehicleData, O…
KhrystynaDubovyk d9e5e0f
Merge branch 'develop' into feature/multiple_modules
KhrystynaDubovyk 31b1fd6
upd Consent diagr;GetCapabilities,GetInteriorVehicleData index minor …
KhrystynaDubovyk 1bf5749
Merge branch 'feature/multiple_modules' of https://github.com/smartde…
KhrystynaDubovyk 468e057
Apply suggestions from code review
KhrystynaDubovyk 69633f8
remove `userLocation` from TTS.SetGlobalProperties
KhrystynaDubovyk 49b982b
remove `defvalue` for `subscribe` param
KhrystynaDubovyk 59936e4
formatting !!! MUST
KhrystynaDubovyk b82314d
fix typos in diagr (concent ->consent)
KhrystynaDubovyk 6588d67
add SetGlobalProperties index
KhrystynaDubovyk a19e0a8
SetGlobalProperties index
KhrystynaDubovyk e34f968
Merge branch 'feature/multiple_modules' of https://github.com/smartde…
KhrystynaDubovyk a72d1d6
add RC_SetGlobalProperties.png,RC_SetGlobalProperties.gliffy
KhrystynaDubovyk 2a62528
add SetGlobalProperties to RC
KhrystynaDubovyk 1c12492
Apply suggestions from code review
KhrystynaDubovyk de249c0
remove p.2
KhrystynaDubovyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -488,6 +488,9 @@ | |
}, | ||
{ | ||
"name": "OnRCStatus" | ||
}, | ||
{ | ||
"name": "SetGlobalProperties" | ||
} | ||
] | ||
}, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
docs/RC/GetInteriorVehicleDataConsent/assets/GetInteriorVehicleDataConsent.gliffy
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file modified
BIN
+99.9 KB
(190%)
docs/RC/GetInteriorVehicleDataConsent/assets/GetInteriorVehicleDataConsent.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
docs/RC/SetGlobalProperties/assets/RC_SetGlobalProperties.gliffy
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
## SetGlobalProperties | ||
|
||
Type | ||
: Function | ||
|
||
Sender | ||
: SDL | ||
|
||
Purpose | ||
: Inform HMI of user location properties set by the application for RC modules allocation purposes | ||
|
||
### Description | ||
SDL requests to set the value of user location sent by a RC application. The default `userLocation` should be `DRIVER`. | ||
The driver's application should be able to control any free module that is allowed by policies(even if the driver's seat is outside the service area of a module). | ||
|
||
### Request | ||
#### Behavior | ||
|
||
!!! MUST | ||
|
||
1. Store the userLocation and associate it with appID. | ||
|
||
!!! | ||
|
||
#### Parameters | ||
|Name|Type|Mandatory|Additional| | ||
|:---|:---|:--------|:---------| | ||
|userLocation|[Common.SeatLocation](../../common/structs/#seatlocation)|false|| | ||
|appID|Integer|true|| | ||
|
||
|
||
### Response | ||
#### Parameters | ||
This RPC has no additional parameter requirements | ||
|
||
### Sequence Diagrams | ||
|
||
||| | ||
SetGlobalProperties | ||
 | ||
||| | ||
|
||
### Example Request | ||
|
||
```json | ||
{ | ||
"id":22, | ||
"jsonrpc":"2.0", | ||
"method":"RC.SetGlobalProperties", | ||
"params":{ | ||
"appID":600980185, | ||
"userLocation":{ | ||
"grid":{ | ||
"col":2, | ||
"colspan":1, | ||
"level":0, | ||
"levelspan":1, | ||
"row":0, | ||
"rowspan":1 | ||
} | ||
} | ||
} | ||
} | ||
``` | ||
|
||
### Example Response | ||
|
||
```json | ||
{ | ||
"id" : 22, | ||
"jsonrpc" : "2.0", | ||
"result" : | ||
{ | ||
"code" : 0, | ||
"method" : "RC.SetGlobalProperties" | ||
} | ||
} | ||
``` | ||
|
||
### Example Error | ||
|
||
```json | ||
{ | ||
"id" : 22, | ||
"jsonrpc" : "2.0", | ||
"error" : | ||
{ | ||
"code" : 22, | ||
"message" : "During API call the unknown error has occurred", | ||
"data" : | ||
{ | ||
"method" : "RC.SetGlobalProperties" | ||
} | ||
} | ||
} | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.