-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL 0312 update minimum required iOS version to 10 #1759
Merged
joeljfischer
merged 106 commits into
develop
from
feature/0312_update_min_required_iOS_version_to_10
Sep 18, 2020
Merged
SDL 0312 update minimum required iOS version to 10 #1759
joeljfischer
merged 106 commits into
develop
from
feature/0312_update_min_required_iOS_version_to_10
Sep 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Removed deprecations and fixed tests Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Added missing tests Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Added missing tests Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Fixed tests Signed-off-by: NicoleYarroch <nicole@livio.io>
Fixed tests Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Fixed test cases Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Fixed how the short app id is generated. Signed-off-by: NicoleYarroch <nicole@livio.io>
joeljfischer
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDLNotificationName has an iOS 9 shim to solve an issue with NSNotificationName
not existing that can be removed.
SDL_SWIFT_ENUM may also be able to be removed (it appears to be an iOS 8 shim).
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Replace the `SDL_SWIFT_ENUM` macro with `NS_TYPED_ENUM` Signed-off-by: NicoleYarroch <nicole@livio.io>
joeljfischer
suggested changes
Sep 17, 2020
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
joeljfischer
suggested changes
Sep 18, 2020
Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
…ion_to_10 Signed-off-by: NicoleYarroch <nicole@livio.io> # Conflicts: # SmartDeviceLink/public/SDLSetGlobalProperties.h # SmartDeviceLink/public/SDLSetGlobalProperties.m # SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLSetGlobalPropertiesSpec.m
Signed-off-by: NicoleYarroch <nicole@livio.io>
joeljfischer
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1738, #1502
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
Unit Tests
Core Tests
If installing using CocoaPods, the user needs to install using a post-install hook that sets the deployment target to 10.0. Otherwise warnings like
'dispatch_queue_create_with_target' is only available on iOS 10.0 or newer
will show up in the project.Core version / branch / commit hash / module tested against: Manticore (SDL Core v6.1.1)
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI v0.8.1)
Summary
SDLLifecycleSystemRequestHandler
class, deprecatedopenURL(_:)
was replaced withopen(_:options:completionHandler:)
.SDLFocusableItemLocator
class, deprecatedpreferredFocusedView
was replaced withpreferredFocusEnvironments
.SDLLogTargetAppleSystemLog
class was deprecated as it uses the deprecatedasl_log_message
API.init
s in RPC requests and responses.SDLPermissionManager
.SDLSyncMsgVersion
class as it has been replaced bySDLMsgVersion
.SDLLockScreenStatus
andSDLOnLockScreenStatus
) private.SDLDisplayType
enum.SDLSeatControlData
using the deprecatedSDLSupportedSeat
enum. Added a newinit
that sets all non-deprecated parameters.SDLPermissionConstants
that are no longer used in the library but were not yet deprecated.Changelog
Breaking Changes
SDLServiceUpdateReason
enum names.Tasks Remaining:
CLA