Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL 0312 update minimum required iOS version to 10 #1759

Merged
merged 106 commits into from
Sep 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
89bbafd
Updated minimum deployment target version
NicoleYarroch Aug 14, 2020
caedace
Fixed deprecation warnings
NicoleYarroch Aug 14, 2020
799cb05
Undo deprecation fix
NicoleYarroch Aug 19, 2020
d31778d
Fixed broken test
NicoleYarroch Aug 19, 2020
8208f3c
Removed available check for queues
NicoleYarroch Aug 19, 2020
807d212
Removed available check for display link log
NicoleYarroch Aug 19, 2020
b8e6e6b
Removed available checks from focusable item mngrs
NicoleYarroch Aug 19, 2020
9a8bcce
Removed available check for os logger
NicoleYarroch Aug 19, 2020
492478f
Removed SDLSyncMsgVersion class
NicoleYarroch Aug 19, 2020
ef35ceb
Removed deprecated VideoStreamingCapability init
NicoleYarroch Aug 19, 2020
5c5e21b
Removed deprecated SeatControlCapabilities init
NicoleYarroch Aug 19, 2020
440070b
Removed deprecated RemoteControlCapabilities init
NicoleYarroch Aug 19, 2020
72fbbdd
Removed deprecated RadioControlData init
NicoleYarroch Aug 20, 2020
a5f32aa
Removed deprecated RadioControlCapabilities init
NicoleYarroch Aug 20, 2020
ea42447
Removed deprecated MediaServiceData init
NicoleYarroch Aug 20, 2020
0d68bf8
Removed deprecated KeyboardProperties init
NicoleYarroch Aug 20, 2020
b591a82
Removed deprecated Image inits
NicoleYarroch Aug 20, 2020
8f05d18
Removed deprecated LightControlCapabilities init
NicoleYarroch Aug 20, 2020
a8d6964
Removed deprecated HMISettingsControlCap inits
NicoleYarroch Aug 20, 2020
8dec58a
Removed deprecated DisplayCapability init
NicoleYarroch Aug 20, 2020
ec371ef
Removed deprecated ClimateControlData init
NicoleYarroch Aug 20, 2020
f74abb4
Removed deprecated ClimateControlCapabilities init
NicoleYarroch Aug 20, 2020
c500be2
Removed deprecated LAudioControlCapabilities inits
NicoleYarroch Aug 20, 2020
b99b918
Removed deprecated SetMediaClockTimer inits
NicoleYarroch Aug 20, 2020
32c7704
Removed deprecated SetGlobalProperties inits
NicoleYarroch Aug 20, 2020
a5335e6
Removed deprecated ScrollableMessage init
NicoleYarroch Aug 20, 2020
c94ee92
Removed deprecated RegisterAppInterface inits
NicoleYarroch Aug 20, 2020
3000e6a
Removed deprecated PutFile init and property
NicoleYarroch Aug 20, 2020
0df18c2
Removed deprecated PerformInteraction inits
NicoleYarroch Aug 20, 2020
e6ffada
Removed deprecated ButtonPress inits
NicoleYarroch Aug 21, 2020
c03ac5f
Removed unnecessary deprecatation #pragmas
NicoleYarroch Aug 21, 2020
64b828a
Removed deprecated Alert inits
NicoleYarroch Aug 21, 2020
f693708
Removed deprecated GetInteriorVehicleDat inits
NicoleYarroch Aug 21, 2020
095fafd
Removed deprecated FileManage init
NicoleYarroch Aug 21, 2020
736116b
Removed deprecated LifecycleConfiguration inits
NicoleYarroch Aug 21, 2020
5349721
Removed deprecated MenuCell inits
NicoleYarroch Aug 21, 2020
8f14b0e
Deprecated Permission Manager inits
NicoleYarroch Aug 21, 2020
7fc4d2e
Fixed Permission Manager tests
NicoleYarroch Aug 24, 2020
8cc9655
Removed old documentation
NicoleYarroch Aug 24, 2020
de1126e
Removed deprecated permission mngr helpers
NicoleYarroch Aug 24, 2020
d91e887
Removed deprecated Manager delegate
NicoleYarroch Aug 26, 2020
397edcd
Removed deprecated KeyboardDelegate method
NicoleYarroch Aug 26, 2020
25516a3
Removed deprecated security managers
NicoleYarroch Aug 26, 2020
d10c8b3
Removed deprecated movementTimeThreshold
NicoleYarroch Aug 26, 2020
d722404
Removed deprecated streaming media inits & methods
NicoleYarroch Aug 26, 2020
e439f19
Removed deprecated Touch Manager init
NicoleYarroch Aug 26, 2020
439a840
Removed deprecated block system cap. observer
NicoleYarroch Aug 26, 2020
b873867
Removed deprecated AddSubMenu inits
NicoleYarroch Aug 26, 2020
8d15f7a
Removed deprecated AddCommand method
NicoleYarroch Aug 26, 2020
07b3802
Removed deprecated lock screen config properties
NicoleYarroch Aug 26, 2020
9929a53
Removed deprecated Configuration inits
NicoleYarroch Aug 26, 2020
38377de
Made lockscreen notification private
NicoleYarroch Aug 27, 2020
27598a1
Removed deprecated getters in RPC Message
NicoleYarroch Aug 27, 2020
eb24af7
Merge branch 'develop' into feature/0312_update_min_required_iOS_vers…
NicoleYarroch Aug 27, 2020
cbd3bb5
Updated the iOS deployment target to 10.0
NicoleYarroch Aug 27, 2020
4f830b6
Increased the compatibilityVersion to Xcode 10
NicoleYarroch Aug 27, 2020
a22195d
Updated the podspec iOS version
NicoleYarroch Aug 27, 2020
05ef425
Updated the podspec iOS version
NicoleYarroch Aug 27, 2020
c5e8543
Deprecated SDLLogTargetAppleSystemLog class
NicoleYarroch Aug 28, 2020
b55078e
Fixed incompatible pointers warning
NicoleYarroch Aug 28, 2020
ca844ea
Cleaned up lifecycleconfiguration inits
NicoleYarroch Aug 28, 2020
5873394
Fixed service update reason enum names
NicoleYarroch Aug 28, 2020
b93679b
Deprecated permission constants
NicoleYarroch Aug 31, 2020
70f7390
Fixed deprecated API preferredFocusedView
NicoleYarroch Sep 1, 2020
049ffa2
Removed unnecessary deprecated-declarations
NicoleYarroch Sep 1, 2020
4065362
Removed available checkes from Swift Ex. App
NicoleYarroch Sep 1, 2020
8a3d044
Merge branch 'develop' into feature/0312_update_min_required_iOS_vers…
NicoleYarroch Sep 3, 2020
7b42029
Relocated previously public files
NicoleYarroch Sep 3, 2020
8603e61
Merge branch 'develop' into feature/0312_update_min_required_iOS_vers…
NicoleYarroch Sep 3, 2020
343b037
Removed deprecated GetVehicleData inits
NicoleYarroch Sep 3, 2020
d746256
Removed deprecated UnsubscribeVehicleData inits
NicoleYarroch Sep 3, 2020
577b94d
Removed deprecated SubscribeVehicleData inits
NicoleYarroch Sep 3, 2020
bbc9e28
Deprecated SeatControlData inits and params
NicoleYarroch Sep 3, 2020
e531251
Fixed deprecated warnings
NicoleYarroch Sep 3, 2020
6e00dac
Added docs for SeatControlData and SupportedSeat
NicoleYarroch Sep 3, 2020
05d3edf
Updated deprecated API in example apps
NicoleYarroch Sep 3, 2020
1166148
Apply suggestions from code review
NicoleYarroch Sep 4, 2020
71cf783
Renamed the TestHapticRectViewController class
NicoleYarroch Sep 4, 2020
10c6797
Fixed how filters are copied
NicoleYarroch Sep 4, 2020
d4e30d1
Fixed incorrect private method prefix
NicoleYarroch Sep 4, 2020
8a86132
Deprecated the old SDLServiceUpdate enums
NicoleYarroch Sep 4, 2020
d44b0ea
Removed unnecessary display capability tests
NicoleYarroch Sep 4, 2020
59d2585
Fixed how the permissions filter is copied
NicoleYarroch Sep 4, 2020
2665099
Fixed SeatControlData init
NicoleYarroch Sep 4, 2020
9bedb8e
Merge branch 'develop' into feature/0312_update_min_required_iOS_vers…
NicoleYarroch Sep 4, 2020
81ee3ea
Converted SDLLockScreenStatus to an enum
NicoleYarroch Sep 4, 2020
a204ce4
Fixed lockscreen status notification & tests
NicoleYarroch Sep 14, 2020
64b6182
Reverted deleted LifecycleConfigurationSpec inits
NicoleYarroch Sep 14, 2020
2a7f5a8
Update SmartDeviceLink/private/SDLPreloadChoicesOperation.m
NicoleYarroch Sep 15, 2020
2198d6d
Renamed SDLOnLockScreenStatus class
NicoleYarroch Sep 15, 2020
cf85435
Fixed lockscreen notification dispatcher
NicoleYarroch Sep 15, 2020
5fef4e9
Removed constant from notification user info
NicoleYarroch Sep 16, 2020
d4e30f7
Fixed description string
NicoleYarroch Sep 16, 2020
c4829b2
Deleted duplicate file
NicoleYarroch Sep 16, 2020
067a1e2
Refactored init formatting
NicoleYarroch Sep 16, 2020
d4f33e7
Fixed file name in doc headers
NicoleYarroch Sep 16, 2020
e31d707
Fix data type in init
NicoleYarroch Sep 16, 2020
301b83a
Removed LifecycleConfiguration inits
NicoleYarroch Sep 16, 2020
756b90d
Removed helper init
NicoleYarroch Sep 17, 2020
928ca8a
Removed if/else for NSNotificationName
NicoleYarroch Sep 17, 2020
3c4d23f
Removed SDL_SWIFT_ENUM macro
NicoleYarroch Sep 17, 2020
b2667d8
Removed SDLMacros.h file
NicoleYarroch Sep 17, 2020
ed73003
Fixed how appId is set in the lifecycle config
NicoleYarroch Sep 17, 2020
6d5f65d
Apply suggestions from code review
NicoleYarroch Sep 18, 2020
b1d640d
Merge branch 'develop' into feature/0312_update_min_required_iOS_vers…
NicoleYarroch Sep 18, 2020
fe1757c
Added menuLayout tests
NicoleYarroch Sep 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Example Apps/Example ObjC/RPCPermissionsManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ + (SDLPermissionGroupStatus)sdlex_checkCurrentGroupPermissionsWithManager:(SDLMa
* @return A unique identifier for the subscription. This can be used to later to unsubscribe from the notifications.
*/
+ (SDLPermissionObserverIdentifier)sdlex_subscribeGroupPermissionsWithManager:(SDLManager *)manager permissionElements:(NSArray<SDLPermissionElement *> *)permissionElements groupType:(SDLPermissionGroupType)groupType {
SDLPermissionObserverIdentifier observerId = [manager.permissionManager subscribeToRPCPermissions:permissionElements groupType:groupType withHandler:^(NSDictionary<SDLPermissionRPCName,SDLRPCPermissionStatus *> * _Nonnull change, SDLPermissionGroupStatus status) {
SDLPermissionObserverIdentifier observerId = [manager.permissionManager subscribeToRPCPermissions:permissionElements groupType:groupType withHandler:^(NSDictionary<SDLRPCFunctionName, SDLRPCPermissionStatus *> * _Nonnull change, SDLPermissionGroupStatus status) {
[self sdlex_logRPCGroupPermissions:permissionElements groupPermissionStatus:status individualPermissionStatuses:change];
}];
return observerId;
Expand Down
21 changes: 3 additions & 18 deletions Example Apps/Example ObjC/VehicleDataManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,6 @@ + (void)getAllVehicleDataWithManager:(SDLManager *)manager triggerSource:(SDLTri
SDLLogD(@"App has permission to access vehicle data. Requesting vehicle data...");

SDLGetVehicleData *getAllVehicleData = [[SDLGetVehicleData alloc] initWithGps:@YES speed:@YES rpm:@YES instantFuelConsumption:@YES fuelRange:@YES externalTemperature:@YES turnSignal:@YES vin:@YES gearStatus:@YES tirePressure:@YES odometer:@YES beltStatus:@YES bodyInformation:@YES deviceStatus:@YES driverBraking:@YES wiperStatus:@YES headLampStatus:@YES engineTorque:@YES accPedalPosition:@YES steeringWheelAngle:@YES engineOilLife:@YES electronicParkBrakeStatus:@YES cloudAppVehicleID:@YES stabilityControlsStatus:@YES eCallInfo:@YES airbagStatus:@YES emergencyEvent:@YES clusterModeStatus:@YES myKey:@YES handsOffSteering:@YES windowStatus:@YES];
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
getAllVehicleData.fuelLevel = @YES;
getAllVehicleData.fuelLevel_State = @YES;
getAllVehicleData.prndl = @YES;
#pragma clang diagnostic pop

[manager sendRequest:getAllVehicleData withResponseHandler:^(__kindof SDLRPCRequest * _Nullable request, __kindof SDLRPCResponse * _Nullable response, NSError * _Nullable error) {
if (error || ![response isKindOfClass:SDLGetVehicleDataResponse.class]) {
Expand Down Expand Up @@ -222,15 +216,9 @@ + (NSString *)sdlex_vehicleDataDescription:(SDLGetVehicleDataResponse *)vehicleD
} else if ([vehicleDataType isEqualToString:ACExternalTemperatureMenuName]) {
vehicleDataDescription = vehicleData.externalTemperature.description;
} else if ([vehicleDataType isEqualToString:ACFuelLevelMenuName]) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
vehicleDataDescription = vehicleData.fuelLevel.description;
#pragma clang diagnostic pop
vehicleDataDescription = vehicleData.fuelRange.firstObject.level.description;
} else if ([vehicleDataType isEqualToString:ACFuelLevelStateMenuName]) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
vehicleDataDescription = vehicleData.fuelLevel_State.description;
#pragma clang diagnostic pop
vehicleDataDescription = vehicleData.fuelRange.firstObject.levelState.description;
} else if ([vehicleDataType isEqualToString:ACFuelRangeMenuName]) {
vehicleDataDescription = vehicleData.fuelRange.description;
} else if ([vehicleDataType isEqualToString:ACGearStatusMenuName]) {
Expand All @@ -246,10 +234,7 @@ + (NSString *)sdlex_vehicleDataDescription:(SDLGetVehicleDataResponse *)vehicleD
} else if ([vehicleDataType isEqualToString:ACOdometerMenuName]) {
vehicleDataDescription = vehicleData.odometer.description;
} else if ([vehicleDataType isEqualToString:ACPRNDLMenuName]) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
vehicleDataDescription = vehicleData.prndl.description;
#pragma clang diagnostic pop
vehicleDataDescription = vehicleData.gearStatus.actualGear.description;
} else if ([vehicleDataType isEqualToString:ACSpeedMenuName]) {
vehicleDataDescription = vehicleData.speed.description;
} else if ([vehicleDataType isEqualToString:ACSteeringWheelAngleMenuName]) {
Expand Down
4 changes: 0 additions & 4 deletions Example Apps/Example Swift/AudioManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ fileprivate enum SpeechRecognitionAuthState {
case authorized, notAuthorized, badRegion
}

@available(iOS 10.0, *)
class AudioManager: NSObject {
fileprivate let sdlManager: SDLManager
fileprivate var audioData: Data?
Expand Down Expand Up @@ -88,7 +87,6 @@ class AudioManager: NSObject {

// MARK: - Audio Pass Thru Notifications

@available(iOS 10.0, *)
private extension AudioManager {
/// SDL streams the audio data as it is collected.
var audioDataReceivedHandler: SDLAudioPassThruHandler? {
Expand Down Expand Up @@ -144,7 +142,6 @@ private extension AudioManager {

// MARK: - Speech Recognition

@available(iOS 10.0, *)
private extension AudioManager {
/// Configures speech recognition
func startSpeechRecognitionTask() {
Expand Down Expand Up @@ -186,7 +183,6 @@ private extension AudioManager {

// MARK: - Speech Recognition Authorization

@available(iOS 10.0, *)
extension AudioManager: SFSpeechRecognizerDelegate {
func speechRecognizer(_ speechRecognizer: SFSpeechRecognizer, availabilityDidChange available: Bool) {
speechRecognitionAuthState = AudioManager.checkAuthorization(speechRecognizer: speechRecognizer)
Expand Down
12 changes: 3 additions & 9 deletions Example Apps/Example Swift/MenuManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,9 @@ private extension MenuManager {
/// - Parameter manager: The SDL Manager
/// - Returns: A SDLMenuCell object
class func menuCellRecordInCarMicrophoneAudio(with manager: SDLManager) -> SDLMenuCell {
if #available(iOS 10.0, *) {
let audioManager = AudioManager(sdlManager: manager)
return SDLMenuCell(title: ACRecordInCarMicrophoneAudioMenuName, icon: SDLArtwork(image: UIImage(named: MicrophoneBWIconImageName)!.withRenderingMode(.alwaysTemplate), persistent: true, as: .PNG), voiceCommands: [ACRecordInCarMicrophoneAudioMenuName], handler: { _ in
audioManager.startRecording()
})
}

return SDLMenuCell(title: ACRecordInCarMicrophoneAudioMenuName, icon: SDLArtwork(image: UIImage(named: SpeakBWIconImageName)!.withRenderingMode(.alwaysTemplate), persistent: true, as: .PNG), voiceCommands: [ACRecordInCarMicrophoneAudioMenuName], handler: { _ in
AlertManager.sendAlert(textField1: "Speech recognition feature only available on iOS 10+", sdlManager: manager)
let audioManager = AudioManager(sdlManager: manager)
return SDLMenuCell(title: ACRecordInCarMicrophoneAudioMenuName, icon: SDLArtwork(image: UIImage(named: MicrophoneBWIconImageName)!.withRenderingMode(.alwaysTemplate), persistent: true, as: .PNG), voiceCommands: [ACRecordInCarMicrophoneAudioMenuName], handler: { _ in
audioManager.startRecording()
})
}

Expand Down
8 changes: 4 additions & 4 deletions Example Apps/Example Swift/VehicleDataManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ extension VehicleDataManager {
guard hasPermissionToAccessVehicleData(with: manager) else { return }

SDLLog.d("App has permission to access vehicle data. Requesting all vehicle data...")
let getAllVehicleData = SDLGetVehicleData(accelerationPedalPosition: true, airbagStatus: true, beltStatus: true, bodyInformation: true, cloudAppVehicleID: true, clusterModeStatus: true, deviceStatus: true, driverBraking: true, eCallInfo: true, electronicParkBrakeStatus: true, emergencyEvent: true, engineOilLife: true, engineTorque: true, externalTemperature: true, fuelLevel: true, fuelLevelState: true, fuelRange: true, gps: true, headLampStatus: true, instantFuelConsumption: true, myKey: true, odometer: true, prndl: true, rpm: true, speed: true, steeringWheelAngle: true, tirePressure: true, turnSignal: true, vin: true, wiperStatus: true)
let getAllVehicleData = SDLGetVehicleData(gps: NSNumber(true), speed: NSNumber(true), rpm: NSNumber(true), instantFuelConsumption: NSNumber(true), fuelRange: NSNumber(true), externalTemperature: NSNumber(true), turnSignal: NSNumber(true), vin: NSNumber(true), gearStatus: NSNumber(true), tirePressure: NSNumber(true), odometer: NSNumber(true), beltStatus: NSNumber(true), bodyInformation: NSNumber(true), deviceStatus: NSNumber(true), driverBraking: NSNumber(true), wiperStatus: NSNumber(true), headLampStatus: NSNumber(true), engineTorque: NSNumber(true), accPedalPosition: NSNumber(true), steeringWheelAngle: NSNumber(true), engineOilLife: NSNumber(true), electronicParkBrakeStatus: NSNumber(true), cloudAppVehicleID: NSNumber(true), stabilityControlsStatus: NSNumber(true), eCallInfo: NSNumber(true), airbagStatus: NSNumber(true), emergencyEvent: NSNumber(true), clusterModeStatus: NSNumber(true), myKey: NSNumber(true), handsOffSteering: NSNumber(true), windowStatus: NSNumber(true))

manager.send(request: getAllVehicleData) { (request, response, error) in
guard didAccessVehicleDataSuccessfully(with: manager, response: response, error: error) else { return }
Expand Down Expand Up @@ -190,9 +190,9 @@ extension VehicleDataManager {
case ACExternalTemperatureMenuName:
vehicleDataDescription = vehicleData.externalTemperature?.description ?? notAvailable
case ACFuelLevelMenuName:
vehicleDataDescription = vehicleData.fuelLevel?.description ?? notAvailable
vehicleDataDescription = vehicleData.fuelRange?.first?.level?.description ?? notAvailable
case ACFuelLevelStateMenuName:
vehicleDataDescription = vehicleData.fuelLevel_State?.rawValue.rawValue ?? notAvailable
vehicleDataDescription = vehicleData.fuelRange?.first?.levelState?.rawValue.rawValue ?? notAvailable
case ACFuelRangeMenuName:
vehicleDataDescription = vehicleData.fuelRange?.description ?? notAvailable
case ACGPSMenuName:
Expand All @@ -206,7 +206,7 @@ extension VehicleDataManager {
case ACOdometerMenuName:
vehicleDataDescription = vehicleData.odometer?.description ?? notAvailable
case ACPRNDLMenuName:
vehicleDataDescription = vehicleData.prndl?.rawValue.rawValue ?? notAvailable
vehicleDataDescription = vehicleData.gearStatus?.actualGear?.rawValue.rawValue ?? notAvailable
case ACSpeedMenuName:
vehicleDataDescription = vehicleData.speed?.description ?? notAvailable
case ACSteeringWheelAngleMenuName:
Expand Down
Loading