-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/0268 Main Menu Updating and Pagination #1433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1433 +/- ##
=============================================
+ Coverage 46.52% 46.58% +0.05%
- Complexity 4978 4995 +17
=============================================
Files 538 541 +3
Lines 27662 27700 +38
Branches 3399 3399
=============================================
+ Hits 12870 12903 +33
- Misses 13863 13870 +7
+ Partials 929 927 -2
|
JulianKast
requested changes
Aug 17, 2020
|
||
/** | ||
* This is a unit test class for the SmartDeviceLink library project class : | ||
* {@link com.smartdevicelink.rpc.OnUpdateSubMenu} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* {@link com.smartdevicelink.rpc.OnUpdateSubMenu} | |
* {@link com.smartdevicelink.proxy.rpc.OnUpdateSubMenu} |
|
||
/** | ||
* This is a unit test class for the SmartDeviceLink library project class : | ||
* {@link com.smartdevicelink.rpc.OnUpdateFile} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* {@link com.smartdevicelink.rpc.OnUpdateFile} | |
* {@link com.smartdevicelink.proxy.rpc.OnUpdateFile} |
JulianKast
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Unit Tests
Updated Unit tests for RPC changes
Core Tests
DynamicUpdateCapabilities
sdlManager.getSystemCapabilityManager().getDefaultMainWindowCapability().getDynamicUpdateCapabilities()
OnUpdateFile
RPCNotification and the parameters work as expectedOnUpdateSubMenu
RPCNotification and the parameters work as expectedThe below PRC can be sent to trigger both
OnUpdateFile
andOnUpdateSubMenu
notificationsCore version / branch / commit hash / module tested against: sdl_core#3455
HMI name / version / branch / commit hash / module tested against: sdl_hmi#385
Summary
This PR adds
OnUpdateFile
andOnUpdateSubMenu
RPCs as described in the proposal.This also adds
DynamicUpdateCapabilities
toWindowCapability
as described in the proposal.CLA