Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/0268 Main Menu Updating and Pagination #1433

Merged
merged 8 commits into from
Aug 17, 2020

Conversation

RHenigan
Copy link
Contributor

@RHenigan RHenigan commented Aug 5, 2020

Fixes #1254

This PR is [ready] for review.

Risk

This PR makes [minor] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

Updated Unit tests for RPC changes

Core Tests

  • Test that you are able to get the DynamicUpdateCapabilities sdlManager.getSystemCapabilityManager().getDefaultMainWindowCapability().getDynamicUpdateCapabilities()
  • Test that you are able to receive an OnUpdateFile RPCNotification and the parameters work as expected
  • Test that you are able to receive an OnUpdateSubMenu RPCNotification and the parameters work as expected

The below PRC can be sent to trigger both OnUpdateFile and OnUpdateSubMenu notifications

AddSubMenu subMenu = new AddSubMenu(2, "Test");
SdlArtwork appIconNewName = new SdlArtwork("FAKE_FILE.png", FileType.GRAPHIC_PNG, R.mipmap.ic_launcher, true);
subMenu.setMenuIcon(appIconNewName.getImageRPC());
sdlManager.sendRPC(subMenu);

Core version / branch / commit hash / module tested against: sdl_core#3455
HMI name / version / branch / commit hash / module tested against: sdl_hmi#385

Summary

This PR adds OnUpdateFile and OnUpdateSubMenu RPCs as described in the proposal.
This also adds DynamicUpdateCapabilities to WindowCapability as described in the proposal.

CLA

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1433 into develop will increase coverage by 0.05%.
The diff coverage is 79.48%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1433      +/-   ##
=============================================
+ Coverage      46.52%   46.58%   +0.05%     
- Complexity      4978     4995      +17     
=============================================
  Files            538      541       +3     
  Lines          27662    27700      +38     
  Branches        3399     3399              
=============================================
+ Hits           12870    12903      +33     
- Misses         13863    13870       +7     
+ Partials         929      927       -2     
Impacted Files Coverage Δ Complexity Δ
...va/com/smartdevicelink/proxy/rpc/OnUpdateFile.java 70.00% <70.00%> (ø) 4.00 <4.00> (?)
...com/smartdevicelink/proxy/rpc/OnUpdateSubMenu.java 76.92% <76.92%> (ø) 6.00 <6.00> (?)
...evicelink/proxy/rpc/DynamicUpdateCapabilities.java 77.77% <77.77%> (ø) 5.00 <5.00> (?)
...com/smartdevicelink/protocol/enums/FunctionID.java 94.40% <100.00%> (+0.09%) 12.00 <0.00> (ø)
...om/smartdevicelink/proxy/rpc/WindowCapability.java 100.00% <100.00%> (ø) 22.00 <2.00> (+2.00)
...martdevicelink/proxy/rpc/enums/ImageFieldName.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...com/smartdevicelink/util/MediaStreamingStatus.java 67.32% <0.00%> (+0.99%) 17.00% <0.00%> (ø%)
... and 1 more

@RHenigan RHenigan marked this pull request as ready for review August 14, 2020 18:35

/**
* This is a unit test class for the SmartDeviceLink library project class :
* {@link com.smartdevicelink.rpc.OnUpdateSubMenu}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* {@link com.smartdevicelink.rpc.OnUpdateSubMenu}
* {@link com.smartdevicelink.proxy.rpc.OnUpdateSubMenu}


/**
* This is a unit test class for the SmartDeviceLink library project class :
* {@link com.smartdevicelink.rpc.OnUpdateFile}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* {@link com.smartdevicelink.rpc.OnUpdateFile}
* {@link com.smartdevicelink.proxy.rpc.OnUpdateFile}

@JulianKast JulianKast merged commit 556350d into develop Aug 17, 2020
@JulianKast JulianKast deleted the feature/0268_MainMenuUpdating_Pagination branch August 17, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants