[0238] Keyboard Enhancements #1587

kboskin · 2020-12-13T14:59:08Z

Fixes #1121

This PR is [ready] for review.

Related PR's

Core
HMI

Risk

This PR makes [minor] API changes.

Testing Plan

I have verified that I have not introduced new warnings in this PR (or explain why below)
I have run the unit tests with this PR
I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
I have tested Android, Java SE, and Java EE

Unit Tests

Added tests to cover new structures and updated existing ones according to the introduced changes

Summary

Changes according to the #1121

CLA

I have signed the CLA

- Implement changes according to the proposal

- Imports rollback

codecov · 2020-12-13T15:09:23Z

Codecov Report

Merging #1587 (ce0c744) into develop (3a84cea) will increase coverage by 0.10%.
The diff coverage is 81.94%.

@@              Coverage Diff              @@
##             develop    #1587      +/-   ##
=============================================
+ Coverage      53.94%   54.04%   +0.10%     
- Complexity      5077     5105      +28     
=============================================
  Files            540      543       +3     
  Lines          23425    23488      +63     
  Branches        2885     2892       +7     
=============================================
+ Hits           12637    12695      +58     
+ Misses          9749     9747       -2     
- Partials        1039     1046       +7

Impacted Files	Coverage Δ	Complexity Δ
...rs/screen/choiceset/PresentChoiceSetOperation.java	`40.71% <0.00%> (-0.50%)`	`17.00 <0.00> (ø)`
...ers/screen/choiceset/PresentKeyboardOperation.java	`38.68% <0.00%> (-0.58%)`	`12.00 <0.00> (ø)`
...anagers/screen/choiceset/BaseChoiceSetManager.java	`38.25% <65.38%> (+3.96%)`	`30.00 <7.00> (+7.00)`
...martdevicelink/proxy/rpc/KeyboardCapabilities.java	`100.00% <100.00%> (ø)`	`6.00 <6.00> (?)`
...devicelink/proxy/rpc/KeyboardLayoutCapability.java	`100.00% <100.00%> (ø)`	`7.00 <7.00> (?)`
.../smartdevicelink/proxy/rpc/KeyboardProperties.java	`83.78% <100.00%> (+3.13%)`	`19.00 <4.00> (+4.00)`
...om/smartdevicelink/proxy/rpc/WindowCapability.java	`100.00% <100.00%> (ø)`	`24.00 <2.00> (+2.00)`
...smartdevicelink/proxy/rpc/enums/KeyboardEvent.java	`100.00% <100.00%> (ø)`	`2.00 <0.00> (ø)`
...tdevicelink/proxy/rpc/enums/KeyboardInputMask.java	`100.00% <100.00%> (ø)`	`2.00 <2.00> (?)`
...martdevicelink/proxy/rpc/enums/KeyboardLayout.java	`100.00% <100.00%> (ø)`	`2.00 <0.00> (ø)`
... and 4 more

santhanamk

@KostyaBoss I have reviewed this PR. I have suggested some changes. Please take a look, and make the changes as needed.

santhanamk · 2020-12-14T15:39:23Z

..._android/src/androidTest/java/com/smartdevicelink/test/rpc/enums/KeyboardInputMaskTests.java

+        List<KeyboardInputMask> enumValueList = Arrays.asList(KeyboardInputMask.values());
+
+        List<KeyboardInputMask> enumTestList = new ArrayList<KeyboardInputMask>();
+        enumTestList.add(KeyboardInputMask.DISABLE_INPUT_KEY_MASK);


@KostyaBoss I would switch lines 62 and 63 so ENABLE comes before DISABLE. In this way, throughout the code the ordering will be consistent (you have ENABLE, DISABLE, and then USER_CHOICE).

santhanamk · 2020-12-14T15:42:45Z

.../src/androidTest/java/com/smartdevicelink/test/rpc/datatypes/ConfigurableKeyboardsTests.java

@@ -0,0 +1,74 @@
+package com.smartdevicelink.test.rpc.datatypes;
+
+import com.smartdevicelink.proxy.rpc.ClusterModeStatus;


@KostyaBoss You can remove the unused import on line 3.

santhanamk · 2020-12-14T15:42:54Z

.../src/androidTest/java/com/smartdevicelink/test/rpc/datatypes/ConfigurableKeyboardsTests.java

+
+import com.smartdevicelink.proxy.rpc.ClusterModeStatus;
+import com.smartdevicelink.proxy.rpc.ConfigurableKeyboards;
+import com.smartdevicelink.proxy.rpc.enums.CarModeStatus;


@KostyaBoss You can remove the unused import on line 5.

santhanamk · 2020-12-14T15:43:12Z

.../src/androidTest/java/com/smartdevicelink/test/rpc/datatypes/ConfigurableKeyboardsTests.java

+import com.smartdevicelink.proxy.rpc.ConfigurableKeyboards;
+import com.smartdevicelink.proxy.rpc.enums.CarModeStatus;
+import com.smartdevicelink.proxy.rpc.enums.KeyboardLayout;
+import com.smartdevicelink.proxy.rpc.enums.PowerModeQualificationStatus;


@KostyaBoss You can remove the unused imports on lines 7 and 8.

santhanamk · 2020-12-14T21:32:09Z

base/src/main/java/com/smartdevicelink/proxy/rpc/KeyboardProperties.java

 */

 public class KeyboardProperties extends RPCStruct {
    public static final String KEY_KEYPRESS_MODE = "keypressMode";
    public static final String KEY_KEYBOARD_LAYOUT = "keyboardLayout";
    public static final String KEY_LIMITED_CHARACTER_LIST = "limitedCharacterList";
+    /**
+     * @since SmartDeviceLink 3.0.0


@KostyaBoss I would suggest deleting lines 134-137. It is correct since it is generated by the code generator tool, but it is out of scope of the PR.

santhanamk · 2020-12-15T01:28:08Z

base/src/main/java/com/smartdevicelink/proxy/rpc/KeyboardCapabilities.java

+     *
+     * @return Boolean Availability of capability to mask input characters using keyboard. True: Available,
+     * False: Not Available
+     * @since SmartDeviceLink 7.1.0


@KostyaBoss I would remove line 131 since it is not part of the proposal's XML.

@santanamk, This file is new and introduced in the XML related. Do we still need to rollback (these changes are from the generator)

@KostyaBoss So I went through the KeyboardCapabilities.java file and the only differences I see is (when comparing my generated file with yours) is in a few places you have added the @ s i n c e SmartDeviceLink 7.1.0 where the generator didn't generate it. I think this is okay. You don't need to change anything.

santhanamk · 2020-12-15T01:36:46Z

...d/src/androidTest/java/com/smartdevicelink/test/rpc/datatypes/KeyboardCapabilitiesTests.java

+                        Hashtable<String, Object> hashTest = JsonRPCMarshaller.deserializeJSONObject(underTestArray.getJSONObject(i));
+                        assertTrue(TestValues.TRUE, Validator.validateConfigurableKeyboards(new ConfigurableKeyboards(hashReference), new ConfigurableKeyboards(hashTest)));
+                    }
+                }/* else if (key.equals(KeyboardCapabilities.KEY_SUPPORTED_KEYBOARD_LAYOUTS)) {


@KostyaBoss Do you need to uncomment lines 81-91 for the KEY_SUPPORTED_KEYBOARD_LAYOUTS?

@santanamk, thanks for bringing this up. I will delete, the layouts test case is covered by the final else branch

santhanamk · 2020-12-15T01:37:32Z

...d/src/androidTest/java/com/smartdevicelink/test/rpc/datatypes/KeyboardCapabilitiesTests.java

+        KeyboardCapabilities msg = new KeyboardCapabilities();
+        assertNotNull(TestValues.NOT_NULL, msg);
+
+        // Keypress mode is created in the object constructor


@KostyaBoss Do you need this comment on line 51?

santhanamk · 2020-12-15T01:45:21Z

android/sdl_android/src/androidTest/java/com/smartdevicelink/test/Validator.java

+        return keyboard1.getKeyboardLayout().equals(keyboard2.getKeyboardLayout()) && keyboard1.getNumConfigurableKeys().equals(keyboard2.getNumConfigurableKeys());
+    }
+
+    public static boolean validateKeyboardCapability(KeyboardCapabilities keyboard1, KeyboardCapabilities keyboard2) {


@KostyaBoss On line 3944 I would rename the parameters to keyboardCapabilities1 and keyboardCapabilities2.

santhanamk · 2020-12-15T01:46:23Z

android/sdl_android/src/androidTest/java/com/smartdevicelink/test/Validator.java

+        return keyboard1.getKeyboardLayout().equals(keyboard2.getKeyboardLayout()) && keyboard1.getNumConfigurableKeys().equals(keyboard2.getNumConfigurableKeys());
+    }
+
+    public static boolean validateKeyboardCapability(KeyboardCapabilities keyboard1, KeyboardCapabilities keyboard2) {


@KostyaBoss I would rename the function on line 3944 to validateKeyboardCapabilities.

- Implement manager updates

- Rollback of the empty method

- Fix pr comments

kboskin · 2020-12-21T19:37:14Z

@santhanamk I've updated the PR, please, re-review

santhanamk

@KostyaBoss I have reviewed the code review changes. The changes look good. I have a few suggestions mostly around the new manager code that you checked in. Please take a look whenever you get the chance.

santhanamk · 2020-12-22T23:25:52Z

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/KeyboardListener.java

@@ -84,4 +84,6 @@
     * @param currentInputText - The user's full current input text
     */
    void onKeyboardDidSendEvent(KeyboardEvent event, String currentInputText);
+
+    void onMaskHasChanged(KeyboardEvent event);


@KostyaBoss On line 88 I would rename this to onKeyboardInputMaskHasChanged().

santhanamk · 2020-12-22T23:36:02Z

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/PresentChoiceSetOperation.java

@@ -338,6 +338,8 @@ public void onNotified(RPCNotification notification) {
                if (onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_VOICE) || onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_SUBMITTED)) {
                    // Submit Voice or Text
                    keyboardListener.onUserDidSubmitInput(onKeyboard.getData(), onKeyboard.getEvent());
+                } else if (onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_ENABLED) || onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_DISABLED)) {


@KostyaBoss Since these enums were most recently added I would move the else if block on lines 341-342 below the last else if (around lines 362-363).

santhanamk · 2020-12-22T23:38:31Z

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/PresentChoiceSetOperation.java

@@ -338,6 +338,8 @@ public void onNotified(RPCNotification notification) {
                if (onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_VOICE) || onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_SUBMITTED)) {
                    // Submit Voice or Text
                    keyboardListener.onUserDidSubmitInput(onKeyboard.getData(), onKeyboard.getEvent());
+                } else if (onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_ENABLED) || onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_DISABLED)) {
+                    keyboardListener.onMaskHasChanged(onKeyboard.getEvent());
                } else if (onKeyboard.getEvent().equals(KeyboardEvent.KEYPRESS)) {


@KostyaBoss Do the unit tests in PresentChoiceSetOperationTests.java need to be updated?

@santanamk there were no tests covering the mask previously so I didn't add some new ones. To my mind, the PresentChoiceSetOperationTests are more about thread-safe testing, but we are not introducing some major changes at this point, so I don't think we should push the changes. Please, let me know if you still think we need to update them

santhanamk · 2020-12-22T23:40:31Z

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/PresentKeyboardOperation.java

@@ -284,6 +284,8 @@ public void onNotified(RPCNotification notification) {
                if (onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_VOICE) || onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_SUBMITTED)) {
                    // Submit Voice or Text
                    keyboardListener.onUserDidSubmitInput(onKeyboard.getData(), onKeyboard.getEvent());
+                } else if (onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_ENABLED) || onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_DISABLED)) {


@KostyaBoss Since these enums were most recently added I would move the else if block on lines 287-288 below the last else if (around line 310).

santhanamk · 2020-12-22T23:41:16Z

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/PresentKeyboardOperation.java

@@ -284,6 +284,8 @@ public void onNotified(RPCNotification notification) {
                if (onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_VOICE) || onKeyboard.getEvent().equals(KeyboardEvent.ENTRY_SUBMITTED)) {
                    // Submit Voice or Text
                    keyboardListener.onUserDidSubmitInput(onKeyboard.getData(), onKeyboard.getEvent());
+                } else if (onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_ENABLED) || onKeyboard.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_DISABLED)) {
+                    keyboardListener.onMaskHasChanged(onKeyboard.getEvent());


@KostyaBoss Do the unit tests in PresentKeyboardOperationTests.java need to be updated?

@santhanamk there were no tests covering the mask previously so I didn't add some new ones. To my mind, the PresentChoiceSetOperationTests are more about thread-safe testing, but we are not introducing some major changes at this point, so I don't think we should push the changes. Please, let me know if you still think we need to update them

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

@@ -541,6 +546,12 @@ public void onCapabilityRetrieved(Object capability) {
                        int currentWindowID = windowCapability.getWindowID() != null ? windowCapability.getWindowID() : PredefinedWindows.DEFAULT_WINDOW.getValue();
                        if (currentWindowID == PredefinedWindows.DEFAULT_WINDOW.getValue()) {
                            defaultMainWindowCapability = windowCapability;
+
+                            KeyboardCapabilities keyboardCapabilities = windowCapability.getKeyboardCapabilities();
+                            if (keyboardCapabilities.getMaskInputCharactersSupported() != null


base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

+                            if (keyboardCapabilities.getMaskInputCharactersSupported() != null
+                                    && !keyboardCapabilities.getMaskInputCharactersSupported()) {
+                                keyboardConfiguration.setMaskInputCharacters(KeyboardInputMask.DISABLE_INPUT_KEY_MASK);
+                            }


kboskin · 2020-12-29T14:49:02Z

@santhanamk I've updated the pr, please, re-review

- Fix PR comments

santhanamk

@KostyaBoss Code looks good. I have approved the PR.

Once you have tested against Core and HMI (if applicable), please put the links for those PRs. Please mark the PR as ready for review, and you can tag Livio once the testing is done on your end.

kboskin · 2021-01-06T21:05:13Z

@bilal-alsharifi , @jordynmackool the PR is ready for the review

jordynmackool · 2021-02-03T21:44:56Z

@KostyaBoss the proposal markdown file has been updated per the revisions included in the accepted with revisions review issue: Revise SDL-0238 Keyboard Enhancements.

Please make the needed updates to this PR and then tag @bilal-alsharifi to review when ready. Thanks!

…ard_enchancements

bilal-alsharifi · 2021-02-08T19:44:26Z

@KostyaBoss @AKalinich-Luxoft is the PR ready for re-review?

AKalinich-Luxoft · 2021-02-09T13:35:50Z

@KostyaBoss @AKalinich-Luxoft is the PR ready for re-review?

@bilal-alsharifi yes, it is ready. Please check for revision changes in cd1136e
Also was pushed 55de319 to resolve the conflicts

# Conflicts: # android/sdl_android/src/androidTest/java/com/smartdevicelink/test/TestValues.java # android/sdl_android/src/androidTest/java/com/smartdevicelink/test/Validator.java

kboskin · 2021-02-11T20:35:57Z

@bilal-alsharifi I've processed the MR conflicts, could you please re-check the PR?

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

base/src/main/java/com/smartdevicelink/proxy/rpc/KeyboardCapabilities.java

base/src/main/java/com/smartdevicelink/proxy/rpc/KeyboardProperties.java

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/KeyboardListener.java

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

- Fix PR formatting comments

- Implement new logic of ChoiseSetManager

- Fix tests

kboskin · 2021-02-15T21:37:15Z

@bilal-alsharifi I've made corresponding changes, could you please check?

base/src/main/java/com/smartdevicelink/proxy/rpc/KeyboardProperties.java

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

- Fix pr comments

- Fix javaDoc

kboskin · 2021-02-17T12:19:12Z

@bilal-alsharifi I've processed the comments, please check the PR

base/src/main/java/com/smartdevicelink/proxy/rpc/KeyboardProperties.java

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

…et/BaseChoiceSetManager.java Co-authored-by: Bilal Alsharifi <599206+bilal-alsharifi@users.noreply.github.com>

…rties.java Co-authored-by: Bilal Alsharifi <599206+bilal-alsharifi@users.noreply.github.com>

- PR suggestions

…nts' into feature/0298_keyboard_enchancements # Conflicts: # base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

- Fix PR

vladmu · 2021-02-18T11:09:42Z

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

@@ -110,6 +113,7 @@
        // capabilities
        currentSystemContext = SystemContext.SYSCTXT_MAIN;
        currentHMILevel = HMILevel.HMI_NONE;
+        keyboardConfiguration = defaultKeyboardConfiguration();


@KostyaBoss this move is not required

vladmu · 2021-02-18T11:17:57Z

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

        if (keyboardConfiguration == null) {
            this.keyboardConfiguration = defaultKeyboardConfiguration();
        } else {
-            KeyboardProperties properties = new KeyboardProperties();
-            properties.setLanguage((keyboardConfiguration.getLanguage() == null ? Language.EN_US : keyboardConfiguration.getLanguage()));
-            properties.setKeyboardLayout((keyboardConfiguration.getKeyboardLayout() == null ? KeyboardLayout.QWERTZ : keyboardConfiguration.getKeyboardLayout()));
-            properties.setKeypressMode((keyboardConfiguration.getKeypressMode() == null ? KeypressMode.RESEND_CURRENT_ENTRY : keyboardConfiguration.getKeypressMode()));
-            properties.setLimitedCharacterList(keyboardConfiguration.getLimitedCharacterList());
-            properties.setAutoCompleteText(keyboardConfiguration.getAutoCompleteText());
-            this.keyboardConfiguration = properties;
+            this.keyboardConfiguration = createValidKeyboardConfigurationBasedOnKeyboardCapabilitiesFromConfiguration(keyboardConfiguration);
        }


Because createValidKeyboardConfigurationBasedOnKeyboardCapabilitiesFromConfiguration could return null we need to avoid setting null to this.keyboardConfiguration please consider my suggestion below:

KeyboardProperties properties = null; if (keyboardConfiguration == null) { properties = createValidKeyboardConfigurationBasedOnKeyboardCapabilitiesFromConfiguration(keyboardConfiguration); } if (properties == null) { this.keyboardConfiguration = defaultKeyboardConfiguration(); } else { this.keyboardConfiguration = properties; }

@vladmu Good point. But I think we should always call createValidKeyboardConfigurationBasedOnKeyboardCapabilitiesFromConfiguration even if the passed keyboardConfiguration is not null right? do you agree with this suggestion?

public void setKeyboardConfiguration(@Nullable KeyboardProperties keyboardConfiguration) { KeyboardProperties properties = createValidKeyboardConfigurationBasedOnKeyboardCapabilitiesFromConfiguration(keyboardConfiguration); if (properties == null) { this.keyboardConfiguration = defaultKeyboardConfiguration(); } else { this.keyboardConfiguration = properties; } }

@vladmu Thanks for the updates! @bilal-alsharifi I've included this as a separate commit, please, let me know if we should revert it

- Fix tests

- Fix Vlad suggestion

kboskin · 2021-02-18T15:37:29Z

@bilal-alsharifi I've processed the changes, please, check the PR

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

- Fix PR comments

kboskin · 2021-02-18T16:51:25Z

@bilal-alsharifi I've processed the comments, please, review

bilal-alsharifi · 2021-02-18T18:53:24Z

@KostyaBoss Thanks for making the changes. I noticed that the CI is taking much longer than usual to run the tests. Can you check that all unit tests pass locally?

kboskin · 2021-02-18T19:19:27Z

@KostyaBoss Thanks for making the changes. I noticed that the CI is taking much longer than usual to run the tests. Can you check that all unit tests pass locally?

@bilal-alsharifi I've run the tests locally, will report the results soon

kboskin · 2021-02-18T19:35:59Z

@bilal-alsharifi here are the results of the tests, those 3, I believe have failed due to run on the emulator, sometimes they work for me in this way

bilal-alsharifi · 2021-02-18T19:59:35Z

I believe the ones that you listed fail because the device that you are testing on is not connected to the internet and thus not able to download the icon.

kboskin · 2021-02-18T20:37:41Z

@bilal-alsharifi observing the same behaviour (with CI) for other PR's as well, seems to be general problem

bilal-alsharifi · 2021-02-19T00:01:03Z

@KostyaBoss I restarted the tests multiple times and they pass now.

kboskin · 2021-02-25T10:10:51Z

@bilal-alsharifi Hi! We've noticed that iOS and JS suites have been merged already, do you have additional feedback on this PR?

bilal-alsharifi · 2021-02-25T14:32:40Z

@KostyaBoss it should be good now. I was just waiting for the other PRs to be ready to make sure all PRs are aligned.

[0238]

e845d20

- Implement changes according to the proposal

kboskin changed the base branch from master to develop December 13, 2020 14:59

[0238]

69609bd

- Imports rollback

santhanamk reviewed Dec 15, 2020

View reviewed changes

kboskin added 3 commits December 17, 2020 14:31

[0238]

a277562

- Implement manager updates

[0238]

55ec1e1

- Rollback of the empty method

[0298]

f841c3a

- Fix pr comments

santhanamk reviewed Dec 22, 2020

View reviewed changes

[0298]

bf77bc5

- Fix PR comments

santhanamk approved these changes Jan 4, 2021

View reviewed changes

kboskin changed the title ~~[0298] Keyboard Enhancements~~ [0238] Keyboard Enhancements Jan 6, 2021

kboskin marked this pull request as ready for review January 6, 2021 20:29

AKalinich-Luxoft added 2 commits February 6, 2021 12:36

Make changes according to revision

cd1136e

Merge remote-tracking branch 'origin/develop' into feature/0298_keybo…

55de319

…ard_enchancements

Merge branch 'develop' into feature/0298_keyboard_enchancements

40766fd

# Conflicts: # android/sdl_android/src/androidTest/java/com/smartdevicelink/test/TestValues.java # android/sdl_android/src/androidTest/java/com/smartdevicelink/test/Validator.java

bilal-alsharifi suggested changes Feb 15, 2021

View reviewed changes

bilal-alsharifi reviewed Feb 15, 2021

View reviewed changes

kboskin added 3 commits February 15, 2021 21:46

[0238]

b8d87df

- Fix PR formatting comments

[0238]

e5b110b

- Implement new logic of ChoiseSetManager

[0238]

6843d63

- Fix tests

bilal-alsharifi reviewed Feb 16, 2021

View reviewed changes

kboskin added 3 commits February 17, 2021 13:28

[0238]

76101c4

- Fix pr comments

[0238]

4629a60

- Fix javaDoc

[0238]

5a09c44

- Fix javaDoc

bilal-alsharifi suggested changes Feb 17, 2021

View reviewed changes

kboskin and others added 6 commits February 18, 2021 12:04

Update base/src/main/java/com/smartdevicelink/managers/screen/choices…

30fdae8

…et/BaseChoiceSetManager.java Co-authored-by: Bilal Alsharifi <599206+bilal-alsharifi@users.noreply.github.com>

Update base/src/main/java/com/smartdevicelink/proxy/rpc/KeyboardPrope…

65ffa59

…rties.java Co-authored-by: Bilal Alsharifi <599206+bilal-alsharifi@users.noreply.github.com>

[0238]

43e14f5

- PR suggestions

Merge remote-tracking branch 'origin/feature/0298_keyboard_enchanceme…

68c28a1

…nts' into feature/0298_keyboard_enchancements # Conflicts: # base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java

[0238]

4361c31

- Fix PR

[0238]

e9f1d03

- Fix PR

vladmu reviewed Feb 18, 2021

View reviewed changes

vladmu mentioned this pull request Feb 18, 2021

[SDL-0238] Keyboard Enhancements smartdevicelink/sdl_javascript_suite#366

Merged

4 tasks

kboskin added 2 commits February 18, 2021 14:55

[0238]

1daa2ae

- Fix tests

[0238]

bf1bc4a

- Fix Vlad suggestion

bilal-alsharifi reviewed Feb 18, 2021

View reviewed changes

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/BaseChoiceSetManager.java Show resolved Hide resolved

[0238]

ce0c744

- Fix PR comments

bilal-alsharifi approved these changes Feb 25, 2021

View reviewed changes

bilal-alsharifi merged commit 0777adc into smartdevicelink:develop Feb 25, 2021

		@@ -0,0 +1,74 @@
		package com.smartdevicelink.test.rpc.datatypes;

		import com.smartdevicelink.proxy.rpc.ClusterModeStatus;

[0238] Keyboard Enhancements #1587

[0238] Keyboard Enhancements #1587

Conversation

kboskin commented Dec 13, 2020 • edited Loading

Related PR's

Risk

Testing Plan

Unit Tests

Summary

CLA

codecov bot commented Dec 13, 2020 • edited Loading

Codecov Report

santhanamk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kboskin commented Dec 21, 2020

santhanamk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

kboskin commented Dec 29, 2020

santhanamk left a comment

Choose a reason for hiding this comment

kboskin commented Jan 6, 2021

jordynmackool commented Feb 3, 2021

bilal-alsharifi commented Feb 8, 2021

AKalinich-Luxoft commented Feb 9, 2021

kboskin commented Feb 11, 2021

kboskin commented Feb 15, 2021

kboskin commented Feb 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bilal-alsharifi Feb 18, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kboskin commented Feb 18, 2021

kboskin commented Feb 18, 2021

bilal-alsharifi commented Feb 18, 2021

kboskin commented Feb 18, 2021

kboskin commented Feb 18, 2021

bilal-alsharifi commented Feb 18, 2021

kboskin commented Feb 18, 2021

bilal-alsharifi commented Feb 19, 2021

kboskin commented Feb 25, 2021

bilal-alsharifi commented Feb 25, 2021

kboskin commented Dec 13, 2020 •

edited

Loading

codecov bot commented Dec 13, 2020 •

edited

Loading

bilal-alsharifi Feb 18, 2021 •

edited

Loading