[SDL-0238] Keyboard Enhancements #366
Conversation
|
@santhanamk the PR is ready for Ford review. |
|
@ymalovanyi is this ready for Livio Reivew? |
|
@jordynmackool @crokita the description was fixed to include all sections from the template and the code was tested against the Core and HMI (corresponded links also included in the description). Please review. Also, please take into account that the JavaScript Suite doesn't contain Choice Set Manager (it seems it will be added in the implementation of https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0272-sdl-javascript-manager-layer.md) therefore only RPC changes of the proposal included here and we have tested this against Core with cases defined in the description. |
|
@ymalovanyi / @vladmu the proposal markdown file has been updated per the revisions included in the accepted with revisions review issue: Revise SDL-0238 Keyboard Enhancements. Please make the needed updates to this PR and then tag @renonick87 to review when ready. Thanks! |
…eyboard-Enhancements # Conflicts: # tests/Test.js
|
@renonick87 all required adjustments were made, the PR is ready for review. |
There was a problem hiding this comment.
@ymalovanyi From an initial review, the content of this PR looks good. But with the addition of the ChoiceSetManager in #371, there are additional updates needed for the manager to support this feature.
…eyboard-Enhancements # Conflicts: # tests/Test.js
|
@renonick87, we've made additional changes to the ChoiceSetManager. Moreover, this aligned with the last state of Java PR smartdevicelink/sdl_java_suite#1587. We have tested the code with the Core/HMI. Please review. |
| @@ -306,6 +306,8 @@ class _PresentChoiceSetOperation extends _Task { | |||
| } else if (onKeyboardInput.getEvent() === KeyboardEvent.ENTRY_ABORTED || onKeyboardInput.getEvent() === KeyboardEvent.ENTRY_CANCELLED) { | |||
| // notify of abort / cancelation | |||
| this._keyboardListener.onKeyboardDidAbortWithReason(onKeyboardInput.getEvent()); | |||
| } else if (onKeyboardInput.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_ENABLED) || onKeyboardInput.getEvent().equals(KeyboardEvent.INPUT_KEY_MASK_DISABLED)) { | |||
There was a problem hiding this comment.
This addition should also be included in the _PresentKeyboardOperation.js file.
|
Hey @renonick87 , changes were added. |
Fixes #340
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Added unit tests cover [SDL-0238] Keyboard Enhancements changes
Core Tests
KeyboardCapabilitiescan be received from HMIKeyboardInputMaskcan be received from HMIKeyboardEventenum contains two additional values"INPUT_KEY_MASK_ENABLED", and"INPUT_KEY_MASK_DISABLED"ConfigurableKeyboardscan be received from HMIkeyboardCapabilitiesproperty is present inWindowCapabilitystruct, and containsconfigurableKeyspropertyKeyboardLayoutenum contains additional value"NUMERIC"maskInputCharactersandcustomizeKeysproperties in the structKeyboardPropertiescan be received from HMISetGlobalPropertiesmessage requestkeyboardPropertiesparameter can be sent withkeyboardLayoutproperty set to"NUMERIC", and definedmaskInputCharactersandcustomizeKeyspropertiesCore version / branch / commit hash / module tested against: LuxoftSDL/sdl_core#sdl_0238_keyboard_enhancements
HMI name / version / branch / commit hash / module tested against: LuxoftSDL/sdl_hmi#sdl_0238_keyboard_enhancements
Summary
Applied [SDL-0238] Keyboard Enhancements changes
Changelog
Breaking Changes
N/AEnhancements
KeyboardCapabilities,ConfigurableKeyboardsKeyboardInputMaskBug Fixes
N/ATasks Remaining:
N/ACLA