DND-1928 Fixed order when searching for repositories in org #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanta
changed the title
…kinsci#653) * [JENKINS-68321] Allow `NoThrottle` to be used even on github.com * Ignoring failing tests
…com (jenkinsci#653)" (jenkinsci#730) This reverts commit 51d5810.
* Add a JDK21 Jenkinsfile for ci.jenkins.io * Update Jenkinsfile
Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 4.73 to 4.74. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.73...plugin-4.74) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
spotoczny
force-pushed
the
DND-1928
branch
2 times, most recently
from
58f915c to
dfe942f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When scanning the organization, repositories are obtained using
searchGH API. Results are paged by100items, in SR we have more repositories so the final result is the result of multiple paged calls. There is no sorting order set when repos are fetched, resulting in abest-matchsorting (according to GH), which occurred to be not stable sort - the same repository was returned twice or even three times on multiple pages and other repositories were lost and as a result, we observed disappearing jobs on Jenkins in Org Folder.This PR adds a stable sorting, based on the repository name, so no results are lost.
DND-1928
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify