This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Python3 support #70
Open
Python3 support #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version can grab pre-made company reports by ID and return them in a variety of formats.
Also added raising of errors on non-200 returns.
…tatus Change to json return on custom reports
Rt/moar methods
Add methods for Table-related API calls
When the field is empty, f['#text'] raises a KeyError.
This is due to the way xmltodict parses:
when the field in an xml tag is empty, '#text' is not defined
Use f.get('#text', None) instead.
A test have been added to check this.
New meta and employees methods See merge request podemos-ti/PyBambooHR!1
Attribute meta_tables was added, keeps data from custom tables See merge request podemos-ti/PyBambooHR!3
Added preferredName to employee record
adding support for effective dates
…ring Add try except for basestring
…bles Employee changed tables
…tom-report Last changed in custom report
New meta and employees methods
allow custom fields in the custom report method
…th_custom_field fix get_employee with custom field
… into python3_support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for Python 2.7 has been discontinued since the start of 2020. This drives multiple projects to upgrade their projects with Python 3.x compatible libraries.
This PR contains the conversion of the code, done with the 2to3 tool. It was done on top of an old branch with the name python3_support, hence the delta of ~100 commits with the master branch.
Existing tests pass, no new tests have been introduced. The library has been tested in production with a real project and shows no regression (note that this being an API - not all of it is used in that project, only functions of interest).
Can be linked with issue https://github.com/smeggingsmegger/PyBambooHR/issues/68