Introduce async SourceFileProvider interface #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a common interface that in future changes will be implemented with a faster alternate that avoids scanning all files in the program during initialization As part of this work, I rework consumers of TypeScriptProgram to be asyncronous, and add runWithConcurrentLimit to fence check in parallel. This is needed because if we were to check all fences in parallel we would hit the system RLIMIT by opening all fences simultaneously. And while I'm in there, I added a progress bar to give user feedback while performing fence checks. This does not display while performing provider initialization, but this is less of a problem against the (yet to come) newer implementation that doesn't perform full typescript program initialization.
smikula
reviewed
Aug 10, 2021
Merged
smikula
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a common interface that in future changes will be implemented
with a faster alternate that avoids scanning all files in the program
during initialization
As part of this work, I rework consumers of TypeScriptProgram to be
asyncronous, and add runWithConcurrentLimit to fence check in parallel.
This is needed because if we were to check all fences in parallel we
would hit the system RLIMIT by opening all fences simultaneously.
I also let runWithConcurrentLimit display a progress bar to give user
feedback while performing fence checks. This does not display during
provider initialization, but this is less of a problem against the (yet
to come) newer implementation that doesn't perform ts program
initialization.