Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEquality hot fix hot fix #819

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Dec 16, 2024

Refactor Equals methods and add IEquatable regions.

Removed Equals from IBioPolymerWithSetMods interface in Omics. This ensures it is called on one class and not the interface ambiguously so that any call in MetaMorhpeus uses the correct equals without needing understanding of the codebase to perform the operation correctly.

  • Updated Equals in PeptideWithSetModifications to check OneBasedStartResidue and Parent?.Accession.
  • Updated Equals in OligoWithSetMods to check FullSequence and DigestionParams?.DigestionAgent.
  • Added IEquatable regions to PeptideWithSetModifications and OligoWithSetMods.
  • Organized Equals methods with #region IEquatable directives.

@nbollis nbollis added the bug label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.25%. Comparing base (90bd259) to head (9bddeed).

Files with missing lines Patch % Lines
...roteolyticDigestion/PeptideWithSetModifications.cs 80.00% 0 Missing and 2 partials ⚠️
...zLib/Transcriptomics/Digestion/OligoWithSetMods.cs 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   77.25%   77.25%   -0.01%     
==========================================
  Files         218      218              
  Lines       33014    33020       +6     
  Branches     3422     3426       +4     
==========================================
+ Hits        25506    25509       +3     
  Misses       6941     6941              
- Partials      567      570       +3     
Files with missing lines Coverage Δ
mzLib/Omics/IBioPolymerWithSetMods.cs 98.68% <ø> (+1.03%) ⬆️
...roteolyticDigestion/PeptideWithSetModifications.cs 95.90% <80.00%> (-0.19%) ⬇️
...zLib/Transcriptomics/Digestion/OligoWithSetMods.cs 86.45% <75.00%> (-0.44%) ⬇️

@nbollis nbollis marked this pull request as ready for review December 16, 2024 21:07
trishorts
trishorts previously approved these changes Dec 16, 2024
Removed Equals from IBioPolymerWithSetMods interface in Omics.
Updated Equals in PeptideWithSetModifications to check OneBasedStartResidue and Parent?.Accession.
Updated Equals in OligoWithSetMods to check FullSequence and DigestionParams?.DigestionAgent.
Added IEquatable regions to PeptideWithSetModifications and OligoWithSetMods.
Organized Equals methods with #region IEquatable directives.
trishorts
trishorts previously approved these changes Dec 17, 2024
trishorts
trishorts previously approved these changes Dec 17, 2024
@trishorts trishorts merged commit dc44773 into smith-chem-wisc:master Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants