chore: address lints in SimpleString Rust #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
requested changes
Apr 26, 2024
There was a problem hiding this comment.
AFAICT the best practice is usually to commit Cargo.lock for binaries, but not for libraries, since the actual dependency resolution happens in consuming projects instead. So I think we should not commit this file.
andrewbanchich
force-pushed
the
andrewbanchich/simplestring-lints
branch
from
a48cd3e
to
c224fcb
Compare
andrewbanchich
force-pushed
the
andrewbanchich/simplestring-lints
branch
from
c224fcb
to
2303061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
#![allow(deprecated)]to silence warning for matching on deprecatedGetStringUTF8Error::Unhandledenum variantuse core::panic;importrustfmtBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.