Update pytest-asyncio to actually run async tests

[jonemo]

While running ./pants test :: on another branch, I noticed two related problems:

1. Async tests (async def test_*) aren't actually running even though they should because we have the asyncio_mode = "auto" setting in pyproject.toml.
2. If any test fails in a file that also contains an async test, the following warning gets output:

=============================== warnings summary ===============================
../../../../../../../Users/jonasneu/.cache/pants/named_caches/pex_root/venvs/s/5cb658c8/venv/lib/python3.11/site-packages/_pytest/config/__init__.py:1249
  /Users/jonasneu/.cache/pants/named_caches/pex_root/venvs/s/5cb658c8/venv/lib/python3.11/site-packages/_pytest/config/__init__.py:1249: PytestConfigWarning: Unknown config option: asyncio_mode
  
    self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")

tests/integration/test_async_stuff.py::test_async
  /Users/jonasneu/.cache/pants/named_caches/pex_root/venvs/s/5cb658c8/venv/lib/python3.11/site-packages/_pytest/python.py:181: PytestUnhandledCoroutineWarning: async def functions are not natively supported and have been skipped.
  You need to install a suitable plugin for your async framework, for example:
    - anyio
    - pytest-asyncio
    - pytest-tornasync
    - pytest-trio
    - pytest-twisted
    warnings.warn(PytestUnhandledCoroutineWarning(msg.format(nodeid)))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
- generated xml file: /private/var/folders/dr/w3lkv8jj0b53yb35jvm79ckc0000gs/T/pants-sandbox-8PioQv/python-packages.smithy-python.tests.integration.test_async_stuff.py@tests.xml -

Simply upgrading pytest and pytest-asyncio to the latest minor versions resolves the issue. I tested this with the following dummy test file:

# test_async_stuff.py

import pytest

async def test_async():
    await sleep(0.1)
    assert False

def test_nonasync():
    assert 1 + 1 == 3

... and seeing two test failures and zero warnings.

Additionally, I removed the repo's one remaining but unnecessary @pytest.mark.asyncio.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[jonemo]

Oh right. And this is the one existing test that has always been broken but previously didn't run. Fix coming in next commit...

[nateprewitt]

For posterity, why wasn't this needed anymore?

[jonemo]

Because we have asyncio-mode set to auto in our configuration file, the marker can be avoided.

Relevant docs are here: https://pytest-asyncio.readthedocs.io/en/latest/reference.html#markers

In auto mode, the pytest.mark.asyncio marker can be omitted, the marker is added automatically to async test functions.

[nateprewitt]

🤦

[jonemo]

What an adventure getting the CI to actually pass on this. Actually had to add an __eq__ to the URI for the formerly silently skipped tests to pass. And then had to deal with a known disagreement between flake8 and mypy. And then I finally got the green check 🎉

Ready for another look.

[nateprewitt]

I think this overall looks great. Thanks for the deep dive @jonemo! I have one comment on the URI that we should take a look at but doesn't need to be part of this PR. Let me know your thoughts, but otherwise, this is fine to merge.

[nateprewitt]

Unrelated to this change, but it's pointing to a couple things I would have noted on the original PR.

URI (and all of our method signatures) should start with (self, *, ...). The goal there is to ensure we only operate with keyword arguments. This provides us more flexibility in ordering on function signatures and prevents breakages with accidental ordering issues.

We should also ideally have these ordered in the constructor (and here) as they appear in the URI when formatted.

{scheme}://{username}:{password}@{host}:{port}{path}{query}{fragment}

We can handle that in a separate PR but should probably track it somewhere unless there's a strong argument with the above.

[jonemo]

My other branch is all about implementing the interfaces as stated in the spec. This PR is just the minimal changes to get asyncio tests working at all. I will take note of this comment for my other branch, but I think I've already got most of it covered there.