Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Lambda service model #361

Merged
merged 4 commits into from
May 13, 2021
Merged

add Lambda service model #361

merged 4 commits into from
May 13, 2021

Conversation

richardhboyd
Copy link

Issue #, if available: #65

Description of changes:
Added Lambda service model and a list-functions example. The example hasn't been tested.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aws/sdk/examples/lambda-list-functions/src/main.rs Outdated Show resolved Hide resolved

let client = Client::from_conf(config);

match client.list_functions().send().await {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Would be also good to send an operation that actually serializes a body that is slightly more complex. And don't feel forced into this CLI style app either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to find one that would work even if the person testing it didn't have any functions in their account. I'll create a better example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that makes sense. I mostly just care that the requests are being serialized / deserialized properly, if you don't use it in an example just knowing that you ran it and it worked is more or less good enough for me.

It also isn't crucial that these examples are runnable, people will more use them to copy-paste code out

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added an invoke-function example. the sigv4 signer is failing on that example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will debug

Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@rcoh rcoh enabled auto-merge (squash) May 13, 2021 14:37
@rcoh rcoh merged commit 0654743 into smithy-lang:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants