Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support primitive ints in status bindings #367

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented May 11, 2021

Issue #, if available: #361
Description of changes: Codegen bug where we were not respecting required fields set by the status code

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from a team May 11, 2021 19:16
Copy link

@kggilmer kggilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcoh rcoh merged commit afee2a6 into main May 11, 2021
@rcoh rcoh deleted the primitive-status-response branch May 11, 2021 19:34
rcoh added a commit that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants