Migrate packages from aws-sdk-js-v3 #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pHandler instance (#3545) * fix(node-http-handler): resolve config provider only once per NodeHttpHandler instance * fix(node-http-handler): test synchronization update
Http2Session keeps node alive even with no requests running, presumably for server pushed streams. This is a behavior change from node's http 1 Agent, which does not keep node alive when there is no request running. Emulate that behavior by unref()ing new sessions, and wrapping requests in a ref() / unref() pair.
… 5-10 mins (#3575)
Adds `reason` property to HttpResponse, which is a simple message explaining the status code. The property is optional, so adding it is backward compatible. Http handlers were updated to populate this property when constructing the HttpResponse, except for the Node http2 handler, because http2 doesn't support an equivalent. Tests were added to Http handlers to make sure the property is populated when available.
Adds the URI type to types package, and uses it in HttpRequest. The URI type adds additional properties that didn't exist on Endpoint. Http handlers were updated to use these new properties when constructing request URLs. Tests were also added to make sure handlers construct URLs properly with the new properties.
srchase
force-pushed
the
middleware-stack-smithy-client
branch
from
7b52c7f to
5013c93
Compare
srchase
changed the title
kuhe
approved these changes
Jun 9, 2023
srchase
force-pushed
the
middleware-stack-smithy-client
branch
6 times, most recently
from
2a7b155 to
37640ed
Compare
srchase
force-pushed
the
middleware-stack-smithy-client
branch
3 times, most recently
from
d5428d1 to
adf94b7
Compare
srchase
force-pushed
the
middleware-stack-smithy-client
branch
from
adf94b7 to
889d21e
Compare
kuhe
approved these changes
Jun 15, 2023
srchase
changed the title
JordonPhillips
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the following packages from the aws/aws-sdk-js-v3 repository to smithy-typescript:
It also updates the
protocol-httpandtypespackages. middleware-endpoint is not migrated from js-v3, but its types are pull into thetypespackage.Once these are published under the @smithy scope, a follow-on PR will update smithy-typescript codegen to use them when generating clients.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.