Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codegen for package migration #791

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jun 22, 2023

This PR updates codegen to use the @smithy NPM packages that were added in #773 and #790.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase force-pushed the codegen-for-package-migration branch from e0ee06e to dfd017c Compare June 26, 2023 18:55
@srchase srchase force-pushed the codegen-for-package-migration branch from dfd017c to 01ad19e Compare June 27, 2023 23:22
Copy link
Contributor

@milesziemer milesziemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the writer.addImports are updated to use the TypeScriptDependency param instead of package name, where others that still are using the package name have just changed the name to use the smithy scope for example. Can we update those too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are still named AWS, even though they're presumably generic client dependencies (ie. smithy scope). Can we change them or is a reason to keep it like that?

@srchase srchase merged commit 244c5ec into smithy-lang:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants