add null terminator to c-string passed to 'libc::open' #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 🦀 , this PR appends a null-terminator(
\0
) to c-string fed tolibc::open
.Function signature of
libc::open
is as follows.open(path: *const c_char, oflag: c_int, ...) -> c_int
Buffer-over-read could happen when the
libc
implementation relies onpath
terminating with a null byte.In
src/phy/sys/tap_interface.rs
, a string fed tolibc::open
is appended with a null terminator.This PR is to do the same thing in
src/phy/sys/bpf.rs
.smoltcp/src/phy/sys/tap_interface.rs
Line 21 in bdfa442
Thank you for reviewing this PR 😺