Changed Dhcpv4Client to use device checksum capabilities #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, the tests are all broken, not sure why. |
|
@whitequark From what I can see, the broken tests have occurred on at least one more PR (#372). I did some digging, and it seems to be something to do with the nightly toolchain. Running the tests locally using the .test_like_travis.rb file, it seems to work fine on Evidentally, something that was commited between those versions breaks something, but I'm not sure what or why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371 by fetching the checksum capabilities from the
Device.Previously, the checksum capabilities were always set to
ChecksumCapabilities::default(), which could mess with the checksum generation.