Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFV configuration benchmark #237

Merged
merged 11 commits into from
Aug 28, 2014
Merged

Conversation

eugeneia
Copy link
Member

This branch factors out load_config from designs/neutron/snabbnfv_traffic to lib.nfv.config.load/lib.nfv.config.apply and adds a benchmark designs/bench/nfvconfig which measures their performance.

This branch also fixes a few bugs in related code paths.

See this wiki page.

@eugeneia eugeneia force-pushed the nfv_config_bench branch 7 times, most recently from a8fe714 to e4a898e Compare August 25, 2014 12:38
lukego added a commit that referenced this pull request Aug 28, 2014
@lukego lukego merged commit d0d65bf into snabbco:master Aug 28, 2014
@eugeneia
Copy link
Member Author

That is wrong indeed, it works if you swap x and y in the second loop but maybe it should just compare #x == #y?

@lukego
Copy link
Member

lukego commented Aug 28, 2014

On 28 August 2014 13:22, Max Rottenkolber notifications@github.com wrote:

That is wrong indeed, it works if you swap x and y in the second loop but
maybe it should just compare '#x == #y`?

The Lua # operator returns creative results when applied to something that
is not an array indexed by 1,2,3,4...

@eugeneia
Copy link
Member Author

Fixed here (also added a regression test): #247

@sleinen
Copy link

sleinen commented Aug 28, 2014

equal() looks good to me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants