Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neutron2snabb egress filters #245

Merged
merged 5 commits into from
Oct 27, 2014
Merged

neutron2snabb egress filters #245

merged 5 commits into from
Oct 27, 2014

Conversation

javierguerragiraldez
Copy link
Contributor

Creates egress filter rules from Neutron config database and sets up a packet_filter app to enforce them.
Fixes some loop reinitialization to let the configDB -> filter rules create more than one filter rules.

I've tested this only with a fake hand-built config database. It does handle anything i throw at it as long as it seems to comply the general syntax, but it would be great if somebody with a Neutron installation could help in more "real worlf" tests.

@eugeneia
Copy link
Member

Minor nitpick: There is a comment

-- XXX This is assumed to be ingress-only. Egress is simply NYI.

at https://github.com/SnabbCo/snabbswitch/pull/245/files#diff-e6dc95ae179bd7a0f203adc2547680c0L84 which I guess can be removed with this commit?

@javierguerragiraldez javierguerragiraldez force-pushed the neutronfilters branch 2 times, most recently from d9364d9 to ad1bc4e Compare September 2, 2014 04:05
@javierguerragiraldez
Copy link
Contributor Author

yes, this was no longer true.

also corrected to respect the merged PR #237, which moved most of the code from designs/neutron/snabbnfv-traffic to lib/nfv/config.lua

@javierguerragiraldez javierguerragiraldez force-pushed the neutronfilters branch 2 times, most recently from 72ef863 to f896738 Compare September 6, 2014 03:46
@javierguerragiraldez
Copy link
Contributor Author

The last commit fixes the merge history mismatch, hopefully the snabbot would approve it!

@javierguerragiraldez javierguerragiraldez force-pushed the neutronfilters branch 3 times, most recently from c7731d3 to 581f55a Compare October 16, 2014 08:19
@javierguerragiraldez javierguerragiraldez force-pushed the neutronfilters branch 2 times, most recently from 3b7ac30 to 2ecb4ae Compare October 22, 2014 05:42
@lukego
Copy link
Member

lukego commented Oct 22, 2014

@eugeneia could you please pull this into your tree, make yourself happy with the way neutron2snabb does packet filtering, and push onward to me?

@eugeneia
Copy link
Member

The neutron2snabb part is fine. We should test this in the nfv/selftest.sh though, but I am very happy with this diff. Don't see any problem.

@eugeneia
Copy link
Member

E.g. just merge this already! ;)

lukego added a commit that referenced this pull request Oct 27, 2014
@lukego
Merge pull request #245 from javierguerragiraldez/neutronfilters
31633c2 
neutron2snabb egress filters
@lukego lukego merged commit 31633c2 into snabbco:master Oct 27, 2014
@lukego
Copy link
Member

lukego commented Oct 27, 2014

Sorry to be slow about that!

@javierguerragiraldez javierguerragiraldez deleted the neutronfilters branch October 29, 2014 04:52
mwiget pushed a commit to mwiget/snabb that referenced this pull request Feb 11, 2016
@wingo
Merge pull request snabbco#245 from Igalia/update-performance
d2761bc 
Update performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javierguerragiraldez @eugeneia @lukego