Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should be an improvement to the react router structure #54

Open
schettn opened this issue Jun 11, 2020 · 0 comments · May be fixed by #52
Open

There should be an improvement to the react router structure #54

schettn opened this issue Jun 11, 2020 · 0 comments · May be fixed by #52
Assignees
@schettn
Labels
enhancement New feature or request
Milestone
SNEK Version 0.1.0

Comments

@schettn
Copy link
Member

schettn commented Jun 11, 2020 •
edited
Loading

Describe the feature or change you'd like
Currently the structure in which the router is implemented does not seem neat. Therefore I suggest following changes:

  • Move the router to index.js
  • Export the App Component like export withRouter(App)to provide the history API

Additional context
Ref: https://developer.mozilla.org/en-US/docs/Web/API/History_API
@schettn schettn added the enhancement New feature or request label Jun 11, 2020
@schettn schettn added this to the SNEK Version 0.1.0 milestone Jun 11, 2020
@schettn schettn self-assigned this Jun 11, 2020
This was referenced Jun 11, 2020
Merged
Merged
@pinterid pinterid linked a pull request Jun 11, 2020 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schettn schettn

Labels
enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging a pull request may close this issue.

Implement 1 to master snek-at/front
1 participant
@schettn