Improve basics aa1 to implement 1 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BrowserRouter has been moved to index.js in order to use withRouter(...) in App.js. Also a router base-name has been added.
- A label was removed due to an error in the MDBSelectOptions element when you click the labelling, the dropdown menu closes. - A icon has been added to the search results. - The profile switching is now handled by the history because `window.open()` is ugly and therefore removed.
A missing import was added in order to user export withRouter(...)
Now it will check if there is platformData in fetchUser. Only when true caching will proceed.
Now there are two functions to check whether a refetch is required or not.
The previous created checking functions are now implemented in the `componentDidMount()` of the Profile Page.
The username is no longer stored in .user but in .profile. Therefore it has been replaced.
A template has been added to ease further use on new machines.
react-scripts has been updated which resolved 2 vulnerabilities.
The package has been upgraded to 0.1.1 to fix a bug when generating talks. Ref: snek-at/intel#83
All headings inside the App component have been replaced with regions.
schettn
added
bug
The issues marked by Codacy were fixed.
pinterid
reviewed
Jun 11, 2020
pinterid
reviewed
Jun 11, 2020
pinterid
reviewed
Jun 11, 2020
pinterid
requested changes
Jun 11, 2020
React-script has been moved to devDependencies. Some newline have been added.
|
I will remove @Aichnerc and @kleberbaum for time reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
snek-intel:v0.1.0is used which produces an error when generating talks. Upgrade snek-intel to v0.1.1 #56.env.templatefile. There should be a template file for .env #57react-scripts:v3.0.1is used which has some security vulnerabilities. Upgrade react-scripts to v3.4.1 #59What is the new behavior (if this is a feature change)?
snek-intel:v0.1.1is used. Therefore there are no more issues related to talk generation. Upgrade snek-intel to v0.1.1 #56.env.templatefile. There should be a template file for .env #57react-scripts:v3.0.1is used and the security vulnerabilities are fixed. Upgrade react-scripts to v3.4.1 #59Other information: