security: update apache/arrow to get security patches on gopkg.in/yaml.v3 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It turns out that this PR will fix #608 |
|
Looks like the |
dominicbarnes
force-pushed
the
update-arrow
branch
from
4f84f26
to
9f59b27
Compare
dominicbarnes
force-pushed
the
update-arrow
branch
from
9f59b27
to
182bcbd
Compare
dominicbarnes
force-pushed
the
update-arrow
branch
from
182bcbd
to
9c12744
Compare
|
I'm still looking to land this security patch, but could use a bit more guidance in order to get it over the finish line. |
dominicbarnes
force-pushed
the
update-arrow
branch
from
51c9c3f
to
9a9e5cf
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
I've discovered that this PR doesn't actually work, seems like the changes to this dependency aren't as clean as I hoped. I will close this PR and re-open when I can get around to testing it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
github.com/apache/arrowwith the primary goal being to land apache/arrow#13322 that includes stretchr/testify#1192 which ultimately updatesgopkg.in/yaml.v3with security patches.To accomplish this, I needed to update imports of apache/arrow to use go modules (which has been adopted by arrow). The closest major version to what existed before is v7, which has no breaking changes for the usage here as far as I can tell. By using go modules like this, it should be easier to manage this dependency, especially if wanting to upgrade to v8 or v9 (current).
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of themCreated tests which fail without the change (if possible)Extended the README / documentation, if necessary