-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gopkg.in/yaml.v3 #1192
Merged
Merged
Update gopkg.in/yaml.v3 #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
approved these changes
May 27, 2022
ghost
approved these changes
May 27, 2022
This was referenced May 29, 2022
Closed
This was referenced May 30, 2022
ajaykn
approved these changes
May 31, 2022
ghost
mentioned this pull request
May 31, 2022
KamilaBorowska
approved these changes
Jun 1, 2022
benjirewis
approved these changes
Jun 2, 2022
boyan-soubachov
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
zeroshade
pushed a commit
to apache/arrow
that referenced
this pull request
Jun 10, 2022
…aml.v3 (v7) This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details. I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred. The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR. Closes #13322 from dominicbarnes/go-security-patch-testify Authored-by: Dominic Barnes <dominic@dbarnes.info> Signed-off-by: Matthew Topol <mtopol@factset.com>
2 tasks
dominicbarnes
added a commit
to segment-boneyard/arrow
that referenced
this pull request
Jul 12, 2022
…aml.v3 (v7) This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details. I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred. The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR. Closes apache#13322 from dominicbarnes/go-security-patch-testify Authored-by: Dominic Barnes <dominic@dbarnes.info> Signed-off-by: Matthew Topol <mtopol@factset.com>
dominicbarnes
added a commit
to segment-boneyard/arrow
that referenced
this pull request
Jul 12, 2022
…aml.v3 (v7) This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details. I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred. The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR. Closes apache#13322 from dominicbarnes/go-security-patch-testify Authored-by: Dominic Barnes <dominic@dbarnes.info> Signed-off-by: Matthew Topol <mtopol@factset.com>
dominicbarnes
added a commit
to segment-boneyard/arrow
that referenced
this pull request
Jul 12, 2022
…aml.v3 (v7) This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details. I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred. The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR. Closes apache#13322 from dominicbarnes/go-security-patch-testify Authored-by: Dominic Barnes <dominic@dbarnes.info> Signed-off-by: Matthew Topol <mtopol@factset.com>
dominicbarnes
added a commit
to segment-boneyard/arrow
that referenced
this pull request
Jul 14, 2022
…aml.v3 (v7) This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details. I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred. The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR. Closes apache#13322 from dominicbarnes/go-security-patch-testify Authored-by: Dominic Barnes <dominic@dbarnes.info> Signed-off-by: Matthew Topol <mtopol@factset.com>
6 tasks
Merged
1 task
kou
pushed a commit
to apache/arrow-go
that referenced
this pull request
Aug 30, 2024
…aml.v3 (v7) This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details. I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred. The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR. Closes #13322 from dominicbarnes/go-security-patch-testify Authored-by: Dominic Barnes <dominic@dbarnes.info> Signed-off-by: Matthew Topol <mtopol@factset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix CVE-2022-28948