-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync @snyk/fix version in CLI with release #1945
Conversation
|
ce53152
to
830e4db
Compare
830e4db
to
e193bae
Compare
e193bae
to
ab99350
Compare
@jahed-snyk for the changes that require both CLI and lib changes we would now have to raise it in the same PR after this change? |
Yes, however it'd be a temporary step until we decide how to properly integrate Lerna's release process. This PR is just experimenting with what routes we can take to avoid double deployments and speed up time-to-release. I don't plan on merging (there are issues with our current CI pipeline) but I'll share my findings in the future to discuss. |
Closing as CLI bundling resolved this. #2105 |
We currently run
update-versions.sh
during release to replace all1.0.0-monorepo
references to the next version being released. So the@snyk/fix
version in the CLI'spackage.json
should also be1.0.0-monorepo
so that it's replaced at the same time too.To Do
@snyk/fix and CLI need to be kept compatible within individual PRs.
Since the npm 7 symlinks dependant workspaces we are mostly testing CLI with the local @snyk/fix rather than whatever version is in the root package.json.
Currently, without this PR, we are testing with a local @snyk/fix and then publishing with a different, older version. Only after we bump that version in the root package.json will we be publishing with the version we're actually testing with.
So it makes sense to keep versions in sync and compatibility is maintained within individual PRs.