Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync @snyk/fix version in CLI with release #1945

Closed
wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2021

We currently run update-versions.sh during release to replace all 1.0.0-monorepo references to the next version being released. So the @snyk/fix version in the CLI's package.json should also be 1.0.0-monorepo so that it's replaced at the same time too.

To Do

@snyk/fix and CLI need to be kept compatible within individual PRs.

Since the npm 7 symlinks dependant workspaces we are mostly testing CLI with the local @snyk/fix rather than whatever version is in the root package.json.

$ cat package.json | fgrep @snyk/fix
    "@snyk/fix": "1.620.0",

$ cat packages/snyk-fix/package.json| fgrep version
  "version": "1.0.0-monorepo",

$ ls -la node_modules/@snyk | grep snyk-fix
lrwxr-xr-x    1 jahed  staff     23 25 May 11:12 fix -> ../../packages/snyk-fix

Currently, without this PR, we are testing with a local @snyk/fix and then publishing with a different, older version. Only after we bump that version in the root package.json will we be publishing with the version we're actually testing with.

So it makes sense to keep versions in sync and compatibility is maintained within individual PRs.

@ghost ghost requested review from a team as code owners May 21, 2021 18:17
@ghost ghost requested a review from tonidevine1 May 21, 2021 18:17
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2021

Fails
🚫

Commit "wip: check what happens" is not a valid commitizen message. See Contributing page with required commit message format.

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against ab99350

@ghost ghost requested a review from lili2311 May 21, 2021 18:31
@ghost ghost force-pushed the chore/sync-snyk-fix-version branch from ce53152 to 830e4db Compare May 24, 2021 13:45
@ghost ghost marked this pull request as draft May 24, 2021 13:55
@ghost ghost force-pushed the chore/sync-snyk-fix-version branch from 830e4db to e193bae Compare May 24, 2021 14:35
@ghost ghost force-pushed the chore/sync-snyk-fix-version branch from e193bae to ab99350 Compare May 24, 2021 18:45
@lili2311
Copy link
Contributor

@jahed-snyk for the changes that require both CLI and lib changes we would now have to raise it in the same PR after this change?

@ghost
Copy link
Author

ghost commented May 25, 2021

@jahed-snyk for the changes that require both CLI and lib changes we would now have to raise it in the same PR after this change?

Yes, however it'd be a temporary step until we decide how to properly integrate Lerna's release process. This PR is just experimenting with what routes we can take to avoid double deployments and speed up time-to-release. I don't plan on merging (there are issues with our current CI pipeline) but I'll share my findings in the future to discuss.

@ghost
Copy link
Author

ghost commented Aug 26, 2021

Closing as CLI bundling resolved this. #2105

@ghost ghost closed this Aug 26, 2021
@darscan darscan deleted the chore/sync-snyk-fix-version branch January 20, 2023 17:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant