Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Webpack One #2105

Merged
merged 1 commit into from
Aug 23, 2021
Merged

The Webpack One #2105

merged 1 commit into from
Aug 23, 2021

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Jul 21, 2021 •
edited
Loading

This PR changes CLI build process to bundle all the code with Webpack before shipping.
This will bring us safer and predictable builds and tests.

Also results in much faster and smaller installation for the users.

I love this show...

@JackuB JackuB force-pushed the feat/webpack branch 30 times, most recently from 548f8bb to e8b60ea Compare July 22, 2021 18:43
@JackuB JackuB force-pushed the feat/webpack branch 2 times, most recently from 6a78090 to fa4c5fc Compare August 20, 2021 08:57
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2021 •
edited
Loading

Messages
📖 You are modifying something in test/smoke directory, yet you are not on the branch starting with smoke/. You can prefix your branch with smoke/ and Smoke tests will trigger for this PR.

Generated by 🚫 dangerJS against e22e94f

@JackuB JackuB force-pushed the feat/webpack branch 10 times, most recently from 1f248a1 to 9cfd778 Compare August 20, 2021 13:05
@JackuB JackuB marked this pull request as ready for review August 20, 2021 13:39
@JackuB JackuB requested review from a team as code owners August 20, 2021 13:39
@JackuB JackuB force-pushed the feat/webpack branch 2 times, most recently from 62587f6 to d10dce2 Compare August 20, 2021 14:03
@JackuB JackuB force-pushed the feat/webpack branch 2 times, most recently from 5b4c398 to c2db53c Compare August 20, 2021 14:22
@JackuB JackuB merged commit 4cc1a94 into master Aug 23, 2021
@JackuB JackuB deleted the feat/webpack branch August 23, 2021 13:47
@ghost ghost mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avishagp Avishagp Avishagp approved these changes

@jan-stehlik jan-stehlik Awaiting requested review from jan-stehlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackuB @Avishagp