-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for gradle's kotlin-dsl #277
feat: Add support for gradle's kotlin-dsl #277
Conversation
@michael-go , 1st sorry for the random ping, How can I ensure this gets someone from snyk's approval ? |
Hi @pastjean 👋 😄 |
Thanks for the quick answer. 🙌 |
As of gradle v5, kotlin-dsl is now official. It still uses the same old methods as gradle but the detection of those project with snyk was broken. This patch adds the support for gradle kotlin-dsl Kotlin-dsl: https://github.com/gradle/kotlin-dsl/ News here: https://github.com/gradle/gradle/releases/tag/v5.0.0-RC2#kotlin-dsl-1.0
@tbroyer is everything good now ? Or do I need more |
Hi! Just to keep you updated this is on my teams radar, there is some upstream work needed to make this mergeable which we are working on :) I see some tests are failing, kicked off the build again seems like a fluke |
d956d67
to
ab6f5c8
Compare
Tests are broken because travis not pass private environment variables to forked code. |
What does this PR do?
As of gradle v5 (soon to be released), kotlin-dsl is now official. It still uses the
same old methods as gradle but the detection of those project with
snyk was broken. This patch adds the support for gradle kotlin-dsl
How should this be manually tested?
Create a
build.gradle.kts
file in a directory with the following content:Any background context you want to provide?
Kotlin-dsl: https://github.com/gradle/kotlin-dsl/
News here: https://github.com/gradle/gradle/releases/tag/v5.0.0-RC2#kotlin-dsl-1.0