Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for gradle's kotlin-dsl #277

Merged
merged 3 commits into from
Mar 18, 2019
Merged

feat: Add support for gradle's kotlin-dsl #277

merged 3 commits into from
Mar 18, 2019

Conversation

pastjean
Copy link
Contributor

@pastjean pastjean commented Nov 20, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

As of gradle v5 (soon to be released), kotlin-dsl is now official. It still uses the
same old methods as gradle but the detection of those project with
snyk was broken. This patch adds the support for gradle kotlin-dsl

How should this be manually tested?

Create a build.gradle.kts file in a directory with the following content:

plugins {
    kotlin("jvm")
}

dependencies {
    implementation(kotlin("stdlib"))
}

Any background context you want to provide?

Kotlin-dsl: https://github.com/gradle/kotlin-dsl/

News here: https://github.com/gradle/gradle/releases/tag/v5.0.0-RC2#kotlin-dsl-1.0

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2018

CLA assistant check
All committers have signed the CLA.

@pastjean
Copy link
Contributor Author

@michael-go , 1st sorry for the random ping,

How can I ensure this gets someone from snyk's approval ?

@michael-go
Copy link
Contributor

Hi @pastjean 👋 😄
There was already some discussion about your PR in Snyk's Slack :) Will make an effort to ping the team.
Thanks! 🙇

@pastjean
Copy link
Contributor Author

Thanks for the quick answer. 🙌

As of gradle v5, kotlin-dsl is now official. It still uses the
same old methods as gradle but the detection of those project with
snyk was broken. This patch adds the support for gradle kotlin-dsl

Kotlin-dsl: https://github.com/gradle/kotlin-dsl/
News here: https://github.com/gradle/gradle/releases/tag/v5.0.0-RC2#kotlin-dsl-1.0
@pastjean
Copy link
Contributor Author

@tbroyer is everything good now ? Or do I need more

@lili2311
Copy link
Contributor

lili2311 commented Mar 12, 2019

Hi! Just to keep you updated this is on my teams radar, there is some upstream work needed to make this mergeable which we are working on :)

I see some tests are failing, kicked off the build again seems like a fluke

@lili2311 lili2311 self-assigned this Mar 14, 2019
@Kirill89 Kirill89 changed the base branch from master to feat/support-gradle-kotlin-script March 18, 2019 10:58
@Kirill89 Kirill89 force-pushed the feat/support-gradle-kotlin-script branch from d956d67 to ab6f5c8 Compare March 18, 2019 11:00
@Kirill89 Kirill89 merged this pull request into snyk:feat/support-gradle-kotlin-script Mar 18, 2019
@Kirill89 Kirill89 mentioned this pull request Mar 18, 2019
3 tasks
@Kirill89
Copy link
Contributor

Tests are broken because travis not pass private environment variables to forked code.
I created different PR and merged your code into it.
@pastjean thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants