Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add build.gradle.kts support #395

Merged
merged 5 commits into from
Mar 18, 2019

Conversation

Kirill89
Copy link
Contributor

@Kirill89 Kirill89 commented Mar 18, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add build.gradle.kts support.

Where should the reviewer start?

#277

Additional Info

What are the relevant tickets?

pastjean and others added 3 commits March 18, 2019 13:07
As of gradle v5, kotlin-dsl is now official. It still uses the
same old methods as gradle but the detection of those project with
snyk was broken. This patch adds the support for gradle kotlin-dsl

Kotlin-dsl: https://github.com/gradle/kotlin-dsl/
News here: https://github.com/gradle/gradle/releases/tag/v5.0.0-RC2#kotlin-dsl-1.0
@Kirill89 Kirill89 self-assigned this Mar 18, 2019
@Kirill89 Kirill89 changed the title Feat/support gradle kotlin script Feat: add build.gradle.kts support Mar 18, 2019
@Kirill89 Kirill89 requested review from lili2311 and adrukh March 18, 2019 11:18
@lili2311
Copy link
Contributor

👍 Please confirm once the upstream change is merged then will approve, looks good 🎉

@Kirill89 Kirill89 closed this Mar 18, 2019
@Kirill89 Kirill89 reopened this Mar 18, 2019
@Kirill89 Kirill89 closed this Mar 18, 2019
@Kirill89 Kirill89 reopened this Mar 18, 2019
@Kirill89 Kirill89 merged commit f551106 into master Mar 18, 2019
@Kirill89 Kirill89 deleted the feat/support-gradle-kotlin-script branch March 18, 2019 17:06
@snyksec
Copy link

snyksec commented Mar 18, 2019

🎉 This PR is included in version 1.137.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants