-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [OSM-1007] Fixing two bugs related to missing .deps
files (.NET Beta)
#5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotkas
changed the title
fix: [OSM-1007] Updating .NET Beta helper text and fixing two bugs related to bad UX and unpublishable projects
fix: [OSM-1007] Fixing two bugs related to bad UX of unpublishable projects (.NET Beta)
May 1, 2024
dotkas
force-pushed
the
dotkas/OSM-1007/prep-for-dotnet-open-beta
branch
from
May 1, 2024 18:15
6c0e422
to
b138259
Compare
dotkas
changed the title
fix: [OSM-1007] Fixing two bugs related to bad UX of unpublishable projects (.NET Beta)
fix: [OSM-1007] Fixing two bugs related to missing May 1, 2024
.deps
files (.NET Beta)
Update with UX improvement on unscannable projects and fixed a bug where the .deps file could not be located in certain cases.
dotkas
force-pushed
the
dotkas/OSM-1007/prep-for-dotnet-open-beta
branch
from
May 1, 2024 18:21
b138259
to
b3611b5
Compare
thisislawatts
approved these changes
May 2, 2024
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Bumps the
snyk-nuget-plugin
to bring the CLI up to date after a few bugfixes has been done in that repo. (1, 2) as well as adding official command line docs to Gitbook at the same time: https://app.gitbook.com/o/-M4tdxG8qotLgGZnLpFR/s/-MdwVZ6HOZriajCf5nXH/~/changes/7042/snyk-cli/commands/testRisk assessment: Low
The plugin updates always gets propagated to our SCM solution first where it is already heavily used, so any issues would automatically be picked up there first.
Where should the reviewer start?
I've added yet another acceptance test which should show the problem (see the
README.md
).How should this be manually tested?
npm link
to the newest version ofsnyk-nuget-plugin
and run that against the fixture added in this repo.Any background context you want to provide?
We're opening up .NET Beta from Closed Beta to Open Beta, hence the doc connection.
What are the relevant tickets?
See
snyk-nuget-plugin
PRs.Screenshots
N/A
Additional questions
N/A