fix: giving user-friendly error when trying to scan unpublishable project #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orsagie
approved these changes
May 1, 2024
DOlufemi
approved these changes
May 1, 2024
dotkas
commented
May 1, 2024
There was a problem hiding this comment.
Test was already covered.
dotkas
force-pushed
the
dotkas/fix-unpublishable-projects
branch
from
ced1b24 to
97cfe08
Compare
dotkas
force-pushed
the
dotkas/fix-unpublishable-projects
branch
from
97cfe08 to
d372af5
Compare
dotkas
force-pushed
the
dotkas/fix-unpublishable-projects
branch
from
f72ed09 to
ebff808
Compare
|
🎉 This PR is included in version 2.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 1, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET solutions with
<IsPublishable>false</IsPublishable>are by definition unscannable by us, as we need the published solution to assess.Currently failing with opaque
dotneterror message. Adding a better UX for our backend to pick up and provide to the end user.Also removing a bunch of checked-in
obj/folders that can deterministically be restored during testing.