Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: eliminate dependency on the gaf #14

Merged
merged 2 commits into from
Mar 25, 2024
Merged

chore!: eliminate dependency on the gaf #14

merged 2 commits into from
Mar 25, 2024

Commits on Mar 25, 2024

  1. chore!: eliminate dependency on the gaf

    The go-application-framework should not be a required dependency of this
    package. It provides only minimal supporting functionality:
    
    - Convenience of access to a logger
    - Convenience of two configuration options (Organization and IsFedramp)
    
    While pulling in a lot of dependencies that a Snyk Code API client does not
    really need. It should not be necessary, for example, to have to know about the GAF's
    workflow engine in order to work with Snyk Code.
    
    This change removes the dependency on the GAF, while leaving room to integrate
    the code client with the GAF in the CLI and LS. This reduction of coupling
    makes the open-source Snyk Code client more relevant to a much wider context of
    reuse.
    cmars committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    03f98c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c82db04 View commit details
    Browse the repository at this point in the history