chore!: eliminate dependency on the gaf #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cmars
force-pushed
the
chore/eliminate-gaf
branch
from
8b97138
to
9d687fa
Compare
| @@ -264,8 +259,6 @@ func TestSnykCodeBackendServicePact_LocalCodeEngine(t *testing.T) { | |||
| Headers: dsl.MapMatcher{ | |||
| "Content-Type": dsl.String("application/json"), | |||
| "snyk-request-id": getSnykRequestIdMatcher(), | |||
| "Session-Token": dsl.Regex("token fc763eba-0905-41c5-a27f-3934ab26786c", sessionTokenMatcher), | |||
There was a problem hiding this comment.
These changes happened because we stopped setting up the configuration with the authentication token, which behind-the-scenes is used to configure these headers for the local code engine mode. I wanted to keep them so that we can make sure the local code engine mode continues to work during this refactoring but I think I can add a test in snyk/snyk-ls#455 instead to make sure these headers are set
teodora-sandu
approved these changes
Mar 25, 2024
|
The security check from |
The go-application-framework should not be a required dependency of this package. It provides only minimal supporting functionality: - Convenience of access to a logger - Convenience of two configuration options (Organization and IsFedramp) While pulling in a lot of dependencies that a Snyk Code API client does not really need. It should not be necessary, for example, to have to know about the GAF's workflow engine in order to work with Snyk Code. This change removes the dependency on the GAF, while leaving room to integrate the code client with the GAF in the CLI and LS. This reduction of coupling makes the open-source Snyk Code client more relevant to a much wider context of reuse.
cmars
force-pushed
the
chore/eliminate-gaf
branch
2 times, most recently
from
a56cbc4
to
52f12e8
Compare
cmars
force-pushed
the
chore/eliminate-gaf
branch
from
52f12e8
to
c82db04
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-application-framework should not be a required dependency of this package. It provides only minimal supporting functionality:
while pulling in a lot of dependencies that a Snyk Code API client does not really need. It should not be necessary, for example, to have to know about the GAF's workflow engine in order to work with Snyk Code.
This change removes the dependency on the GAF, while leaving room to integrate the code client with the GAF in the CLI and LS. This reduction of coupling makes the open-source Snyk Code client more relevant to a much wider context of reuse.