Merge pull request #51 from snyk/fix/handle_empty_projects

fix: make sure that the projects const is iteratable
snyk · Apr 15, 2019 · 4808252 · 4808252
2 parents b8857e5 + 4cd2bc2
commit 4808252
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 1 deletion.
diff --git a/lib/nuget-parser/packages-config-parser.js b/lib/nuget-parser/packages-config-parser.js
@@ -10,7 +10,9 @@ function parsePackagesConfigFileContents(fileContent) {
  if (err) {
  throw err;
  } else {
- result.packages.package.forEach(
+ const packages = result.packages.package || [];
+
+ packages.forEach(
  function scanPackagesConfigNode(node) {
  const installedDependency =
  Dependency.from.packgesConfigEntry(node);

diff --git a/test/parse-packages-config-no-deps.test.js b/test/parse-packages-config-no-deps.test.js
@@ -0,0 +1,21 @@
+'use strict';
+
+const test = require('tap').test;
+const plugin = require('../lib/index');
+const projectPath = './test/stubs/packages-config-no-deps/';
+
+test('parse packages-config-no-deps project successfully', function (t) {
+ plugin.inspect(
+ projectPath,
+ 'packages.config',
+ {
+ packagesFolder: projectPath + './_packages',
+ })
+ .then(function () {
+ t.pass('parsed file correctly');
+ t.end();
+ })
+ .catch(function () {
+ t.fail('failed parsing a project with no deps');
+ });
+});
diff --git a/test/stubs/packages-config-no-deps/nodeps.csproj b/test/stubs/packages-config-no-deps/nodeps.csproj
@@ -0,0 +1,5 @@
+<Project Sdk="Microsoft.NET.Sdk.Web">
+ <PropertyGroup>
+ <TargetFramework>netcoreapp2.0</TargetFramework>
+ </PropertyGroup>
+</Project>
diff --git a/test/stubs/packages-config-no-deps/packages.config b/test/stubs/packages-config-no-deps/packages.config
@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+</packages>