Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure that the projects const is iteratable #51

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

odinn1984
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

when testing against a packages.config file that has no deps we got an error stating that
we cannot do forEach on undefined, this PR fixes that.

@odinn1984 odinn1984 self-assigned this Apr 15, 2019
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Kirill89 Kirill89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/stubs/packages-config-no-deps/nodeps.csproj is unnecessary for this test. Let's simplify it.

👍

when testing against a packages.config file that has no deps we got an error stating that
we cannot do forEach on undefined, this PR fixes that.
@odinn1984 odinn1984 merged commit 4808252 into master Apr 15, 2019
@odinn1984 odinn1984 deleted the fix/handle_empty_projects branch April 15, 2019 13:02
@snyksec
Copy link

snyksec commented Apr 15, 2019

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants