Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump engine.io-client to version 2.0.2 #1074

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

sgress454
Copy link
Contributor

Includes the following (from engine.io-client changelog):

  • [chore] Bump ws to version 1.1.2 (vulnerability fix) (#539)
  • [fix] Fix extraHeaders option in browser (#536)

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Socket.io-client installs version 2.0.0 of the engine.io-client dependency.

New behaviour

Socket.io-client installs version 2.0.2 of the engine.io-client dependency.

Other information (e.g. related issues)

As with socket.io, it might be worth considering changing this dependency to at least use a ~ (i.e. 'engine.io-client': '~2.0.0', but again, I get it.

Includes the following (from engine.io-client changelog):

* [chore] Bump ws to version 1.1.2 (vulnerability fix) ([socketio#539](socketio/engine.io-client#539))
* [fix] Fix extraHeaders option in browser ([socketio#536](socketio/engine.io-client#536))
@darrachequesne darrachequesne merged commit 1ac8374 into socketio:master Feb 16, 2017
@darrachequesne
Copy link
Member

@sgress454 thanks!

@darrachequesne darrachequesne added this to the 2.0.0 milestone Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants