New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribes before calling onopen (1.0) #539

Closed

nkzawa wants to merge 1 commit into socketio:master from nkzawa:openerror

Contributor

nkzawa commented Apr 14, 2013

Errors happen when you open another new connection with a namespace after establishing the connection.

Uncaught TypeError: Cannot call method 'push' of undefined
Uncaught TypeError: Cannot read property 'length' of undefined


          subscribes before calling onopen

cb86421

nkzawa closed this

sgress454 added a commit to sgress454/socket.io-client that referenced this pull request


          Bump engine.io-client to version 2.0.2

4c79a5f

Includes the following (from engine.io-client changelog):

* [chore] Bump ws to version 1.1.2 (vulnerability fix) ([socketio#539](socketio/engine.io-client#539))
* [fix] Fix extraHeaders option in browser ([socketio#536](socketio/engine.io-client#536))

darrachequesne pushed a commit that referenced this pull request


          [chore] Bump engine.io-client to version 2.0.2 (#1074)

1ac8374

Includes the following (from engine.io-client changelog):

* [chore] Bump ws to version 1.1.2 (vulnerability fix) ([#539](socketio/engine.io-client#539))
* [fix] Fix extraHeaders option in browser ([#536](socketio/engine.io-client#536))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet