Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox does a CORS request (OPTION method) before sending POST requests. #194

Closed
wants to merge 389 commits into from
Closed

Firefox does a CORS request (OPTION method) before sending POST requests. #194

wants to merge 389 commits into from

Conversation

saschagehlich
Copy link

Firefox does a CORS request (OPTION method) before sending POST requests. This fix handles this correctly and returns some headers to tell the browser that POST requests are okay.

rauchg and others added 30 commits September 10, 2010 13:36
…onclose netserver.close will fail because netserver will be undefined.
…and over again just makes no sense + it hurt performance.. Not to mention.. that it's already included.
Removed `.test` suffix from tests
Updated node-websocket-client
[ocd] fix
… is the default encoding for http.ServerResponse.write

replaced string.length with Buffer.byteLength in jsonp-polling.js, listener.js and xhr-polling.js because content-length header requires number of bytes and not the number of symbols in string
Starting converting back to spaces to comply with node coding standards
Typo fix in flash socket warning message
Removed accidental 1==2 for serving the not modified status code for the client
Finished websocket test
@3rd-Eden
Copy link
Contributor

Awesome, did this solve 'all' your connection issues?

@saschagehlich
Copy link
Author

I Hope so, actually I didn't put it into production yet but I will later this night. I will also try to figure out what's wrong with XHR-Multipart.

Am 23.04.2011 um 21:35 schrieb 3rd-Edenreply@reply.github.com:

Awesome, did this solve 'all' your connection issues?

Reply to this email directly or view it on GitHub:
https://github.com/LearnBoost/Socket.IO-node/pull/194#issuecomment-1048219

@rauchg
Copy link
Contributor

rauchg commented May 7, 2011

I'm closing this one due to the fact that a preflight request is only needed when the Content-Type is other than text/plain. This is the case for POST right now, but only because we're unnecessarily encoding the payload in the application/x-www-form-urlencoded content type, which has been addressed now.

Thanks again, as usual, @saschagehlich.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.