Don't use EPOLLONESHOT for the wakeup event. (#68)

socketry · Aug 16, 2023 · 2483f4e · 2483f4e
1 parent 3fc744c
commit 2483f4e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/ext/io/event/selector/epoll.c b/ext/io/event/selector/epoll.c
@@ -254,7 +254,7 @@ void IO_Event_Interrupt_add(struct IO_Event_Interrupt *interrupt, struct IO_Even
 	int descriptor = IO_Event_Interrupt_descriptor(interrupt);
 
 	struct epoll_event event = {
-		.events = EPOLLIN|EPOLLRDHUP|EPOLLONESHOT,
+		.events = EPOLLIN|EPOLLRDHUP,
 		.data = {.fd = -1},
 	};
 

diff --git a/test/io/event/selector.rb b/test/io/event/selector.rb
@@ -61,6 +61,21 @@ def transfer
 			thread.join
 		end
 
+		it "can wakeup selector from different thread twice in a row" do
+			2.times do
+				thread = Thread.new do
+					sleep 0.1
+					selector.wakeup
+				end
+
+				expect do
+					selector.select(0.5)
+				end.to have_duration(be < 0.5)
+			ensure
+				thread.join
+			end
+		end
+
 		it "ignores wakeup if not selecting" do
 			expect(selector.wakeup).to be == false
 		end