Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use EPOLLONESHOT for the wakeup event. #68

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Don't use EPOLLONESHOT for the wakeup event. #68

merged 1 commit into from
Aug 16, 2023

Conversation

Math2
Copy link
Contributor

@Math2 Math2 commented Aug 16, 2023

Types of Changes

  • Bug fix.

Contribution

@ioquatix
Copy link
Member

Sorry, it's not immediately obvious what problem is being fixed, do you mind giving a little more context?

@Math2
Copy link
Contributor Author

Math2 commented Aug 16, 2023

EPoll#wakeup only works the first time. The wakeup event is only ever being registered once (in IO_Event_Interrupt_add), so it shouldn't be one-shot.

@ioquatix ioquatix merged commit 2483f4e into socketry:main Aug 16, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Math2 @ioquatix