Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Initiators support from connector side #1175

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

sushanthakumar
Copy link
Contributor

@sushanthakumar sushanthakumar commented Jan 17, 2020

What this PR does / why we need it:
Initiator info can be more than one set, Current connector code supports only one set of initiator to be returned. So getInitiatorInfo() need to support returning multiple initiator info

All the connectors which implement this interface will have to change to support list of initiators

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This PR addresses the hotpot side fixes for the issue sodafoundation/nbp#323

Special notes for your reviewer:

Any other PR(s) this PR is dependant on: None

Testcases to execute:
Verify the initiator info in the host for different connectors

Release note:

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1175 into development will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           development    #1175   +/-   ##
============================================
  Coverage        34.82%   34.82%           
============================================
  Files               97       97           
  Lines            17622    17622           
============================================
  Hits              6137     6137           
  Misses           10614    10614           
  Partials           871      871
Impacted Files Coverage Δ
pkg/dock/discovery/discovery.go 33.51% <0%> (ø) ⬆️

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit e2323ad into sodafoundation:development Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants