Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSI] Support for multiple initiator infos #335

Merged

Conversation

sushanthakumar
Copy link
Collaborator

@sushanthakumar sushanthakumar commented Jan 21, 2020

What this PR does / why we need it:
Currently nbp csi plugins(block/file) supports extracting only one set of initiator info .
Even if the connector provides multiple initiators info for any volume driver, they are not consumed and utilised properly

This fix enables CSI to extracts and use multiple initiators info for any volume driver

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This PR will fix nbp csi side issue for : #323

Special notes for your reviewer:

Any other PR(s) this PR is dependant on: sodafoundation/api#1175

Test Steps:
Bringup csi block and file plugins
Verify the initiator info in the host for different connectors

Release note:

@sushanthakumar sushanthakumar changed the base branch from master to development January 21, 2020 06:56
@sushanthakumar sushanthakumar changed the title CSI support for multiple initiator infos [CSI] Support for multiple initiator infos Jan 21, 2020
@sushanthakumar
Copy link
Collaborator Author

This fix is based on current csi design
However we can relook into current mechanism and improvise as mentioned in the issue (#347)

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit 70d6eab into sodafoundation:development Feb 5, 2020
kumarashit added a commit that referenced this pull request Feb 28, 2020
* Adding First set of Unit Test files for VRO

* ReadMe and Configuration file for VRO test Automation

*  format test files, correct spacing

* NGC Automation for OpenSDS adapter

* hostpath type change for iscsi dir (#10)

* vendor changes update

* Fix for list snapshot issue

* add only snapshots whose status is available to the list

*  Fix for 341 342 309

* [CSI] Update version of k8s csi container images  (#333)

* Update version of k8s csi image (#7)

* csi image version update for file plugin deployment

Co-authored-by: Erik <lynheell@gmail.com>
Co-authored-by: Ashit Kumar <akopensrc@gmail.com>

* [CSI] Support for multiple initiator infos (#335)

* Initiator fix

* Update vendor

Co-authored-by: Erik <lynheell@gmail.com>
Co-authored-by: Ashit Kumar <akopensrc@gmail.com>

* [CSI] Removal of host devices during volume detach (#336)

* remove host device while unstage

* Fix sg_scan not found issue (#6)

Co-authored-by: liuqing <liuqinguestc@163.com>

* Update csi/plugins/block/volume.go

Co-Authored-By: Ashit Kumar <akopensrc@gmail.com>

Co-authored-by: zengyingzhe <52645009+zengyingzhe@users.noreply.github.com>
Co-authored-by: Erik <lynheell@gmail.com>
Co-authored-by: liuqing <liuqinguestc@163.com>
Co-authored-by: Ashit Kumar <akopensrc@gmail.com>

*  Declaring constants for unit tests

* DatastoreServiceImpl create method Unit testing (#350)

* 	modified:   pom.xml
	new file:   src/test/java/service/impl/DatastoreTest.java

* 	renamed:    src/test/java/service/impl/DatastoreTest.java -> src/test/java/org/opensds/vmware/ngc/service/impl/DatastoreTest.java

* 	modified:   src/test/java/org/opensds/vmware/ngc/service/impl/DatastoreTest.java

Co-authored-by: Ashit Kumar <akopensrc@gmail.com>

* Delete Gopkg.lock

* Revert "Delete Gopkg.lock"

This reverts commit e2d8d3e.

* syncing with dec

*  updating default test config values

*  updating default test config values

* Conflict resolution

* vendor update based on v0.10.0 (#364)

Co-authored-by: Najmudheen <45681499+NajmudheenCT@users.noreply.github.com>

Co-authored-by: Najmudheen <45681499+NajmudheenCT@users.noreply.github.com>
Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
Co-authored-by: Erik <lynheell@gmail.com>
Co-authored-by: zengyingzhe <52645009+zengyingzhe@users.noreply.github.com>
Co-authored-by: liuqing <liuqinguestc@163.com>
Co-authored-by: soumiksgithub <soumik.ghosh4@wipro.com>
Co-authored-by: Sanil Kumar <skdsanil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants