-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSI] Support for multiple initiator infos #335
Merged
kumarashit
merged 5 commits into
sodafoundation:development
from
sushanthakumar:Initiator-fix-ToDev
Feb 5, 2020
Merged
[CSI] Support for multiple initiator infos #335
kumarashit
merged 5 commits into
sodafoundation:development
from
sushanthakumar:Initiator-fix-ToDev
Feb 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushanthakumar
changed the title
CSI support for multiple initiator infos
[CSI] Support for multiple initiator infos
Jan 21, 2020
This fix is based on current csi design |
kumarashit
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NajmudheenCT
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kumarashit
added a commit
that referenced
this pull request
Feb 28, 2020
* Adding First set of Unit Test files for VRO * ReadMe and Configuration file for VRO test Automation * format test files, correct spacing * NGC Automation for OpenSDS adapter * hostpath type change for iscsi dir (#10) * vendor changes update * Fix for list snapshot issue * add only snapshots whose status is available to the list * Fix for 341 342 309 * [CSI] Update version of k8s csi container images (#333) * Update version of k8s csi image (#7) * csi image version update for file plugin deployment Co-authored-by: Erik <lynheell@gmail.com> Co-authored-by: Ashit Kumar <akopensrc@gmail.com> * [CSI] Support for multiple initiator infos (#335) * Initiator fix * Update vendor Co-authored-by: Erik <lynheell@gmail.com> Co-authored-by: Ashit Kumar <akopensrc@gmail.com> * [CSI] Removal of host devices during volume detach (#336) * remove host device while unstage * Fix sg_scan not found issue (#6) Co-authored-by: liuqing <liuqinguestc@163.com> * Update csi/plugins/block/volume.go Co-Authored-By: Ashit Kumar <akopensrc@gmail.com> Co-authored-by: zengyingzhe <52645009+zengyingzhe@users.noreply.github.com> Co-authored-by: Erik <lynheell@gmail.com> Co-authored-by: liuqing <liuqinguestc@163.com> Co-authored-by: Ashit Kumar <akopensrc@gmail.com> * Declaring constants for unit tests * DatastoreServiceImpl create method Unit testing (#350) * modified: pom.xml new file: src/test/java/service/impl/DatastoreTest.java * renamed: src/test/java/service/impl/DatastoreTest.java -> src/test/java/org/opensds/vmware/ngc/service/impl/DatastoreTest.java * modified: src/test/java/org/opensds/vmware/ngc/service/impl/DatastoreTest.java Co-authored-by: Ashit Kumar <akopensrc@gmail.com> * Delete Gopkg.lock * Revert "Delete Gopkg.lock" This reverts commit e2d8d3e. * syncing with dec * updating default test config values * updating default test config values * Conflict resolution * vendor update based on v0.10.0 (#364) Co-authored-by: Najmudheen <45681499+NajmudheenCT@users.noreply.github.com> Co-authored-by: Najmudheen <45681499+NajmudheenCT@users.noreply.github.com> Co-authored-by: Ashit Kumar <akopensrc@gmail.com> Co-authored-by: Erik <lynheell@gmail.com> Co-authored-by: zengyingzhe <52645009+zengyingzhe@users.noreply.github.com> Co-authored-by: liuqing <liuqinguestc@163.com> Co-authored-by: soumiksgithub <soumik.ghosh4@wipro.com> Co-authored-by: Sanil Kumar <skdsanil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently nbp csi plugins(block/file) supports extracting only one set of initiator info .
Even if the connector provides multiple initiators info for any volume driver, they are not consumed and utilised properly
This fix enables CSI to extracts and use multiple initiators info for any volume driver
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #This PR will fix nbp csi side issue for : #323
Special notes for your reviewer:
Test Steps:
Bringup csi block and file plugins
Verify the initiator info in the host for different connectors
Release note: