-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge development branch into master for v0.10.2 release #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development
Development
[CSI] Remove alteration of fstab during volume mount/unmount
[CSI] hostpath type change for iscsi directory
* Update version of k8s csi image (#7) * csi image version update for file plugin deployment Co-authored-by: Erik <lynheell@gmail.com> Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
* Initiator fix * Update vendor Co-authored-by: Erik <lynheell@gmail.com> Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
* remove host device while unstage * Fix sg_scan not found issue (#6) Co-authored-by: liuqing <liuqinguestc@163.com> * Update csi/plugins/block/volume.go Co-Authored-By: Ashit Kumar <akopensrc@gmail.com> Co-authored-by: zengyingzhe <52645009+zengyingzhe@users.noreply.github.com> Co-authored-by: Erik <lynheell@gmail.com> Co-authored-by: liuqing <liuqinguestc@163.com> Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
* modified: pom.xml new file: src/test/java/service/impl/DatastoreTest.java * renamed: src/test/java/service/impl/DatastoreTest.java -> src/test/java/org/opensds/vmware/ngc/service/impl/DatastoreTest.java * modified: src/test/java/org/opensds/vmware/ngc/service/impl/DatastoreTest.java Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
skdwriting
requested review from
a team,
skdwriting,
NajmudheenCT and
kumarashit
and removed request for
a team
February 13, 2020 06:35
NajmudheenCT
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kumarashit
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Vendor conflict resolution
skdwriting
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Najmudheen <45681499+NajmudheenCT@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # Multiple fixes for CSI adn Vmware plugin
Special notes for your reviewer:
Changes are tested on development branch. Basic sanity for all these changes done on development branch
Release note: