Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSI] Remove alteration of fstab during volume mount/unmount #337

Merged
merged 1 commit into from
Feb 5, 2020
Merged

[CSI] Remove alteration of fstab during volume mount/unmount #337

merged 1 commit into from
Feb 5, 2020

Conversation

sushanthakumar
Copy link
Collaborator

@sushanthakumar sushanthakumar commented Jan 21, 2020 •
edited
Loading

What this PR does / why we need it:
This fix removes the /etc/fstab alteration during volume mount and unmount

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This fix addresses the issue : #328

Special notes for your reviewer:

Any other PR(s) this PR is dependant on: sodafoundation/api#1192

Test Steps:

Create pod which uses pvc (volume mount will happen)
Verify that /etc/fstab is not altered during the operation
Delete pod
Verify that /etc/fstab is not altered during the pod delete operation as well

Release note:

@sushanthakumar sushanthakumar changed the title Remove alteration of fstab during volume mount/unmount [CSI] Remove alteration of fstab during volume mount/unmount Jan 21, 2020
@sushanthakumar sushanthakumar changed the base branch from master to development January 21, 2020 09:45
NajmudheenCT
NajmudheenCT approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kumarashit
kumarashit approved these changes Feb 5, 2020
View reviewed changes
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit 5473324 into sodafoundation:development Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumarashit kumarashit kumarashit approved these changes

@NajmudheenCT NajmudheenCT NajmudheenCT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushanthakumar @NajmudheenCT @kumarashit