Remove the alteration of fstab during volume mount/unmount #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enhance the volume detachment process * Update oceanstor.go * Remove fstab writing code
Codecov Report
@@ Coverage Diff @@
## development #1192 +/- ##
============================================
Coverage 34.82% 34.82%
============================================
Files 97 97
Lines 17622 17622
============================================
Hits 6137 6137
Misses 10614 10614
Partials 871 871 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fix removes the /etc/fstab alteration during volume mount and unmount at connector side
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #This PR addresses the hotpot side fix for the issue: sodafoundation/nbp#328
Special notes for your reviewer:
Test Steps:
Create pod which uses pvc (volume mount will happen)
Verify that /etc/fstab is not altered during the operation
Delete pod
Verify that /etc/fstab is not altered during the pod delete operation as well
Also the scenarios of mount/unmount without csi need to be tested
Release note: