Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Fixes #205. Added Host management feature. #210

Merged
merged 8 commits into from
Nov 22, 2019

Conversation

anvithks
Copy link
Member

@anvithks anvithks commented Nov 15, 2019

Added the host management feature.
User can perform the following:

  • Add an existing Agentless host
  • View the list of hosts available.
  • View the details of a single host
  • Expand the details in the host list.
  • Delete a single host.
  • Batch delete multiple hosts.
  • List Attached volumes and Initiators
  • Modify host (To be fixed in Modify Host added by the user #213 )

Screenshots:
List Hosts
list-hosts

Add Host
create-host

Add Host Basic Validations
create-host-validation

Expand Host Details
exapnd-details

Host Details
host-deatils

@anvithks anvithks added DAITO feature New feature labels Nov 15, 2019
@anvithks anvithks added this to the Daito SODA v1.0 milestone Nov 15, 2019
@anvithks anvithks self-assigned this Nov 15, 2019
@anvithks anvithks changed the base branch from master to development November 18, 2019 08:53
@anvithks
Copy link
Member Author

@wisererik and @kumarashit Please review the PR.
Modify host feature will be added in #213

@anvithks
Copy link
Member Author

In list host page the overflowing availability zones issue seen in the screenshots above is fixed.

@anvithks anvithks changed the title [WIP] [FEATURE] Fixes #205. Added Host management feature. [FEATURE] Fixes #205. Added Host management feature. Nov 21, 2019
src/app/i18n/en/keyID.json Show resolved Hide resolved
src/app/business/block/hosts.component.ts Outdated Show resolved Hide resolved
src/app/business/block/hosts.component.ts Outdated Show resolved Hide resolved
@kumarashit
Copy link
Collaborator

One generic comment for the UI, we are using 'Please' word everywhere like "Please select host" "Please choose a protocol"..IMO, we should avoid using 'please' word unless we are asking some inconvenient input from user.
Just a thought

@anvithks
Copy link
Member Author

One generic comment for the UI, we are using 'Please' word everywhere like "Please select host" "Please choose a protocol"..IMO, we should avoid using 'please' word unless we are asking some inconvenient input from user.
Just a thought

Generally it is to keep the tone polite. It is again a perception thing whether we consider saying please only for an inconvenience. We can review the overall messages and tone when we start the rewrite of the dashboard. I will add this is a ToDo for the design phase.

@skdwriting
Copy link
Collaborator

@anvithks how did we test these dashboard changes? Can we keep a clear test information on this?

@skdwriting
Copy link
Collaborator

@anvithks how did we test these dashboard changes? Can we keep a clear test information on this?

We do not have the backend ready yet right?

@anvithks
Copy link
Member Author

@anvithks how did we test these dashboard changes? Can we keep a clear test information on this?

@skdwriting These are tested with @wisererik s local dev environment. They have not been tested with a backend created from development branch yet.

@anvithks
Copy link
Member Author

@kumarashit @skdwriting Please review and merge

@kumarashit
Copy link
Collaborator

LGTM

kumarashit
kumarashit previously approved these changes Nov 22, 2019
@wisererik wisererik merged commit 0afed07 into sodafoundation:development Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DAITO feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants