-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Fixes #205. Added Host management feature. #210
[FEATURE] Fixes #205. Added Host management feature. #210
Conversation
@wisererik and @kumarashit Please review the PR. |
In list host page the overflowing availability zones issue seen in the screenshots above is fixed. |
One generic comment for the UI, we are using 'Please' word everywhere like "Please select host" "Please choose a protocol"..IMO, we should avoid using 'please' word unless we are asking some inconvenient input from user. |
Generally it is to keep the tone polite. It is again a perception thing whether we consider saying please only for an inconvenience. We can review the overall messages and tone when we start the rewrite of the dashboard. I will add this is a ToDo for the design phase. |
@anvithks how did we test these dashboard changes? Can we keep a clear test information on this? |
We do not have the backend ready yet right? |
@skdwriting These are tested with @wisererik s local dev environment. They have not been tested with a backend created from development branch yet. |
@kumarashit @skdwriting Please review and merge |
LGTM |
Added the host management feature.
User can perform the following:
Screenshots:
List Hosts
Add Host
Add Host Basic Validations
Expand Host Details
Host Details