[Feature] Fixes #209. Added Host attach and Detach to Volume. #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is tested with @wisererik environment with real API responses. This PR depends on #210 getting merged as there are dependencies pushed in that PR. |
anvithks
changed the title
|
@kumarashit @wisererik Please review and merge |
wisererik
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: #210 has been merged so this PR can be reviewed and merged.
Depends on #210. Please do not merge without merging #210Added the attach / detach hosts feature to volumes.
The user can do the following:
Screenshots:
Attach Host
Attach Host Success
Detach Host
Detach Host when no attachment
Host Tab in Volume Details
Host Detach in Volume Details Host Tab
