Fixed the issue with modify user. Removed validation for tenant #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvithks
added
the
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug fix
What this PR does / why we need it:
This PR fixes the issue of user unable to submit the modify user form.
The same form is used for create and modify user, using a conditional check to display the fields.
In the modify user form the tenant field is not shown but the validation of
requiredwas still applied. This rendered the form always invalid, even if all the fields in the modify form were correctly filled.When the user clicks on modify, the
requiredvalidation on tenant is not needed as the user cannot change the tenant.The
requiredvalidation is now removed and the user is now able to update and submit the modify user form.Which issue(s) this PR fixes:
Fixes #565 #361
Test Report Added?:
/kind TESTED
Test Report:
Special notes for your reviewer: