Remove bezier high order

[hdeling]

Removal of Bezier tetrahedron elements and Bezier triangle elements : move to a new plugin SofaHighOrderTopology

[matthieu-nesme]

I guess this will break the Flexible plugin compilation.
Do you plane to commit it back in a public plugin? In which case, Flexible could link with this plugin.

[hdeling]

Hi,

In fact, I have created an external plugin SOFA-HighOrderTopology which
is intended to be made public.

Either this plugin can be added in the list of "official plugins" such
as Compliant or handled completely separately from the SOFA git hub
repository.

I would like to hear your opinion on where this should go. Either
situations is fine with me.

Best,

Herve

Le 04/10/2016 à 18:32, Matthieu Nesme a écrit :

I guess this will break the Flexible plugin compilation.
Do you plane to commit it back in a public plugin? In which case,
Flexible could link with this plugin.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASgmq8hnFA9IIvByk7zU7_0X80h2cFTlks5qwn-BgaJpZM4JwvD8.

[matthieu-nesme]

Hi Hervé,

In general, I think it is a good idea to have a repo per plugin, even if it becomes more difficult to update them when the sofa core is modified.
But in this specific case, it would be great to add this plugin to this github repo, so Flexible can still benefit from your code.

Another solution, could be to add a third plugin in your independent repository, that would link with both SOFA-HighOrderTopology and Flexible, and that would contain the high order shape functions.

What do you think?

[thomas-lemaire]

yet an other option is to conditionnaly compile HighOrderTopology code in Flexible based on whether the HighOrderTopology plugin is existing or not (in cmakelists package_require(HighOrderTopology) if (HighOrderTopology_FOUND) ... ):

• each plugin can live in its own repository
• no need for a third plugin
• should work whether all the plugins are compiled in the same cmake build project or are compiled/installed separately (well HighOrderTopology must be available when compiling Flexible)

thomas

----- Mail original -----

De: "Matthieu Nesme" notifications@github.com
À: "sofa-framework/sofa" sofa@noreply.github.com
Envoyé: Mercredi 5 Octobre 2016 13:55:09
Objet: Re: [sofa-framework/sofa] Remove bezier high order (#16)

Hi Hervé,

In general, I think it is a good idea to have a repo per plugin, even if it
becomes more difficult to update them when the sofa core is modified.
But in this specific case, it would be great to add this plugin to this
github repo, so Flexible can still benefit from your code.

Another solution, could be to add a third plugin in your independent
repository, that would link with both SOFA-HighOrderTopology and Flexible,
and that would contain the high order shape functions.

What do you think?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub , or mute the thread .

[hdeling]

OK I agree that this allows to compile Flexible without the SOFA-HighOrder.

Before moving SOFA-HighOrder to the gitHub repo, do any of you know if
there are plans to move those plugins outside of github ?

My understanding is that at some point SOFA was going to be cut into
several pieces that could be optionally compiled.

Is this still on the radar ?

Hervé

Le 05/10/2016 à 15:27, thomas-lemaire a écrit :

yet an other option is to conditionnaly compile HighOrderTopology code
in Flexible based on whether the HighOrderTopology plugin is existing
or not (in cmakelists package_require(HighOrderTopology) if
(HighOrderTopology_FOUND) ... ):

• each plugin can live in its own repository
• no need for a third plugin
• should work whether all the plugins are compiled in the same cmake
  build project or are compiled/installed separately (well
  HighOrderTopology must be available when compiling Flexible)

thomas

----- Mail original -----

De: "Matthieu Nesme" notifications@github.com
À: "sofa-framework/sofa" sofa@noreply.github.com
Envoyé: Mercredi 5 Octobre 2016 13:55:09
Objet: Re: [sofa-framework/sofa] Remove bezier high order (#16)

Hi Hervé,

In general, I think it is a good idea to have a repo per plugin,
even if it
becomes more difficult to update them when the sofa core is modified.
But in this specific case, it would be great to add this plugin to this
github repo, so Flexible can still benefit from your code.

Another solution, could be to add a third plugin in your independent
repository, that would link with both SOFA-HighOrderTopology and
Flexible,
and that would contain the high order shape functions.

What do you think?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub , or mute the thread .

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASgmq2nsUCIg4ENi5aade6s7Ah995OVBks5qw6XNgaJpZM4JwvD8.

[thomas-lemaire]

The questions of conditional compilation (plugin selection at cmake), and repository split are distinct, the idea is flying in the air, but nothing concrete, the main issue (I think) is integrating the several repositories in a single continuous integration platform, not a big deal, but it has to be done

thomas

----- Mail original -----

De: "hdeling" notifications@github.com
À: "sofa-framework/sofa" sofa@noreply.github.com
Cc: "thomas-lemaire" thomas.lemaire@inria.fr, "Comment"
comment@noreply.github.com
Envoyé: Mercredi 5 Octobre 2016 17:52:58
Objet: Re: [sofa-framework/sofa] Remove bezier high order (#16)

OK I agree that this allows to compile Flexible without the SOFA-HighOrder.

Before moving SOFA-HighOrder to the gitHub repo, do any of you know if
there are plans to move those plugins outside of github ?

My understanding is that at some point SOFA was going to be cut into
several pieces that could be optionally compiled.

Is this still on the radar ?

Hervé

Le 05/10/2016 à 15:27, thomas-lemaire a écrit :

yet an other option is to conditionnaly compile HighOrderTopology code
in Flexible based on whether the HighOrderTopology plugin is existing
or not (in cmakelists package_require(HighOrderTopology) if
(HighOrderTopology_FOUND) ... ):

• each plugin can live in its own repository
• no need for a third plugin
• should work whether all the plugins are compiled in the same cmake
  build project or are compiled/installed separately (well
  HighOrderTopology must be available when compiling Flexible)

thomas

----- Mail original -----

De: "Matthieu Nesme" notifications@github.com
À: "sofa-framework/sofa" sofa@noreply.github.com
Envoyé: Mercredi 5 Octobre 2016 13:55:09
Objet: Re: [sofa-framework/sofa] Remove bezier high order (#16)

Hi Hervé,

In general, I think it is a good idea to have a repo per plugin,
even if it
becomes more difficult to update them when the sofa core is modified.
But in this specific case, it would be great to add this plugin to this
github repo, so Flexible can still benefit from your code.

Another solution, could be to add a third plugin in your independent
repository, that would link with both SOFA-HighOrderTopology and
Flexible,
and that would contain the high order shape functions.

What do you think?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub , or mute the thread .

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASgmq2nsUCIg4ENi5aade6s7Ah995OVBks5qw6XNgaJpZM4JwvD8.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub , or mute the thread .

[damienmarchal]

Hi all,

I see no conclusion on this specific pull-request ... does it still have to be opened or doest it have to be closed (or merged) ?

DM.

[matthieu-nesme]

This merge is not possible.

Hervé, first you have to know your own fork (or a more global fork you could create for asclepios) can be compiled in the sofa continuous integration system.

To include your work about high order topology in the sofa-public w/o breaking existing stuff, my suggestion is to create a new plugin in your fork, then to propose it here as a pull request. Once you'll have created the PR, we'll be able to possibly fix the glue with Flexible.

[hugtalbot]

Since we discussed this and Matthieu described above the steps to follow I close this PR.
Let us know if you need any assistance Hervé,

Cheers !